Rename entryPoint to entrypoint #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 09c3540 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Nov 22, 2023
matthewp
reviewed
Nov 22, 2023
| null, | ||
| `The injected route "${injectRoute.pattern}" by ${integration.name} specifies the entry point with the "entryPoint" property. This property is deprecated, please use "entrypoint" instead.` | ||
| ); | ||
| injectRoute.entrypoint = injectRoute.entryPoint as string; |
There was a problem hiding this comment.
can't wait until 5.0 to remove this :D
matthewp
approved these changes
Nov 22, 2023
sarah11918
reviewed
Nov 22, 2023
sarah11918
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Warning looks good! I left a comment re: changeset.
And noticed that @bluwy is way ahead of me and has already added this to the Breaking changes tracker issue in docs! Perfect!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There's only one instance where we use
entryPointwhich is for theinjectRoute()API. This PR renames it toentrypoint, and emit a warning if the old name is usedTesting
Existing tests should pass.
Docs
withastro/docs#5475
I also added a warning at
packages/astro/src/integrations/index.ts