-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename entryPoint to entrypoint #9161
Conversation
🦋 Changeset detectedLatest commit: 09c3540 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
null, | ||
`The injected route "${injectRoute.pattern}" by ${integration.name} specifies the entry point with the "entryPoint" property. This property is deprecated, please use "entrypoint" instead.` | ||
); | ||
injectRoute.entrypoint = injectRoute.entryPoint as string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't wait until 5.0 to remove this :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning looks good! I left a comment re: changeset.
And noticed that @bluwy is way ahead of me and has already added this to the Breaking changes tracker issue in docs! Perfect!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
There's only one instance where we use
entryPoint
which is for theinjectRoute()
API. This PR renames it toentrypoint
, and emit a warning if the old name is usedTesting
Existing tests should pass.
Docs
withastro/docs#5475
I also added a warning at
packages/astro/src/integrations/index.ts