feat(cloudflare): support vite plugins options#13278
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
| ## Options | ||
|
|
||
| The Cloudflare adapter accepts the following options: | ||
| The Cloudflare adapter accepts the following options from [`@cloudflare/vite-plugin`](https://developers.cloudflare.com/workers/vite-plugin/): |
There was a problem hiding this comment.
I'm going to guess that this link is the best one we have? On that page it says absolutely nothing about these options, but I also couldn't easily find anywhere these 6 options were all mentioned together. (The first 4 are mentioned on the specific API page - https://developers.cloudflare.com/workers/vite-plugin/reference/api/ but the last two are not)
There was a problem hiding this comment.
Yeah maybe we could link to https://developers.cloudflare.com/workers/vite-plugin/reference/api/#interface-pluginconfig but otherwise, I also failed to find docs for the rest
There was a problem hiding this comment.
I'll let you make the call! The API reference page is maybe marginally more helpful in our immediate context of saying you can set these options? But the above link is the "entry page" to everything about the plugin itself, which is a perfectly reasonable thing to link to when mentioning it for the first time! If there were a more obvious link, we'd use it. Right now, I don't think there's a clear winner, so go with your gut!
|
@sarah11918 can I get your review on the associated changeset? |
Description (required)
Related issues & labels (optional)
For Astro version:
6.x. See astro PR #15556.