Skip to content

feat(cloudflare): support vite plugins options#15556

Merged
florian-lefebvre merged 6 commits intomainfrom
feat/cf-plugin-options
Feb 24, 2026
Merged

feat(cloudflare): support vite plugins options#15556
florian-lefebvre merged 6 commits intomainfrom
feat/cf-plugin-options

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Feb 17, 2026

Changes

  • Addresses https://github.com/orgs/withastro/projects/21/views/1?pane=issue&itemId=154871760 (feedback from James: we should be able to forward some options to the cf vite plugin)
  • The CF adapter now accepts relevant options from the vite plugin. I chose to use Pick instead of Omit to avoid conflicts with our own options and control better what we support
  • I checked the CF docs on what these options were doing before adding support for them and it made sense to me. I basically omitted all the ones that we already set
  • I had to rely on globalThis to pass options to astro preview

Testing

Manual

Docs

@florian-lefebvre florian-lefebvre self-assigned this Feb 17, 2026
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 17, 2026
@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 17, 2026 16:37
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a thought below, but non-blocking!

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 70c663d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@florian-lefebvre florian-lefebvre merged commit 8fb329b into main Feb 24, 2026
21 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/cf-plugin-options branch February 24, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants