Skip to content

Comments

feat(typescript): extract extend global types to its own section#12388

Merged
ArmandPhilippot merged 2 commits intowithastro:mainfrom
ArmandPhilippot:feat/typescript-extend-global-types
Sep 22, 2025
Merged

feat(typescript): extract extend global types to its own section#12388
ArmandPhilippot merged 2 commits intowithastro:mainfrom
ArmandPhilippot:feat/typescript-extend-global-types

Conversation

@ArmandPhilippot
Copy link
Member

Description (required)

  • Adds a new "Extending global types" section in guides/typescript.mdx:

    • move Extending windows & globalThis as a subheading
    • create a Add non-standard attributes subheading and move a part of Built-in HTML attributes in it
    • create a new Using imports subheading (and its contents) to hopefully solve Update documentation on 'Middleware types' #11759 and all the similar issues we had
  • Removes a duplicated link in "Import Aliases" (which I found confusing as a user and I don't think this is great for screen readers as well)

  • Updates pages mentioning .d.ts files to add direct or indirect linking (when the environment variable guide might be more appropriate) to the new Typescript guide section.
    I used ReadMore links for the CMS guides but I noticed we lack of consistency here: when linking to the environment variables page, some use :::note, some use :::tip and only a few use ReadMore. 😅

Related issues & labels (optional)

@ArmandPhilippot ArmandPhilippot added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Sep 22, 2025
@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d14245
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68d1b345526dca0008fc8c8c
😎 Deploy Preview https://deploy-preview-12388--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 22, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/cms/builderio.mdx Source changed, localizations will be marked as outdated.
en/guides/cms/datocms.mdx Source changed, localizations will be marked as outdated.
en/guides/cms/strapi.mdx Source changed, localizations will be marked as outdated.
en/guides/environment-variables.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/alpinejs.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/cloudflare.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/netlify.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/vercel.mdx Source changed, localizations will be marked as outdated.
en/guides/middleware.mdx Source changed, localizations will be marked as outdated.
en/guides/sessions.mdx Source changed, localizations will be marked as outdated.
en/guides/typescript.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really nice improvement! 🎉

@ArmandPhilippot ArmandPhilippot merged commit 077a480 into withastro:main Sep 22, 2025
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the feat/typescript-extend-global-types branch September 22, 2025 20:43
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Sep 23, 2025
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract JSX augmentation to its own section

3 participants