feat(typescript): extract extend global types to its own section#12388
Merged
ArmandPhilippot merged 2 commits intowithastro:mainfrom Sep 22, 2025
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
approved these changes
Sep 22, 2025
Member
sarah11918
left a comment
There was a problem hiding this comment.
This looks like a really nice improvement! 🎉
This was referenced Sep 23, 2025
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Sep 23, 2025
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Sep 23, 2025
This was referenced Sep 23, 2025
This was referenced Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Adds a new "Extending global types" section in
guides/typescript.mdx:Extending windows & globalThisas a subheadingAdd non-standard attributessubheading and move a part ofBuilt-in HTML attributesin itUsing importssubheading (and its contents) to hopefully solve Update documentation on 'Middleware types' #11759 and all the similar issues we hadRemoves a duplicated link in "Import Aliases" (which I found confusing as a user and I don't think this is great for screen readers as well)
Updates pages mentioning
.d.tsfiles to add direct or indirect linking (when the environment variable guide might be more appropriate) to the new Typescript guide section.I used
ReadMorelinks for the CMS guides but I noticed we lack of consistency here: when linking to the environment variables page, some use:::note, some use:::tipand only a few useReadMore. 😅Related issues & labels (optional)
add new content,improve or update documentation