-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple cdn v2 #10189
Add multiple cdn v2 #10189
Conversation
🦋 Changeset detectedLatest commit: 2371fb7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting a "docs block" on this one because the documentation changes are needed to the config reference source file in this repo, not in a separate docs PR.
I will address the content of the docs material in withastro/docs#6982 initially, but in fact those changes will need to be made to https://github.com/withastro/astro/blob/main/packages/astro/src/%40types/astro.ts and that Docs PR will be closed.
DOCS UPDATE: The docs content has been initially reviewed in the docs PR, and is ready to be added here as an edit to |
* main: (327 commits) [ci] format fix(node): listen on 0.0.0.0 if server.host is set to true (withastro#10282) [ci] format fix(dev): cosider `base` when special-casing `/_image` (withastro#10274) [ci] format update login flow to support Brave (withastro#10258) [ci] format improve link command (withastro#10257) Updates deprecated Node.js 16 github actions (withastro#10270) Fix Vitest check fail again (withastro#10266) [ci] format Adds auto completion of `astro:` events when adding or removing event listeners on `document` (withastro#10263) Update Vite to latest (withastro#10259) [ci] release (withastro#10236) [ci] format fix(i18n): localised index pages are overwritten (withastro#10250) fix: change strategy for route caching (withastro#10248) Fix TypeScript type definitions for `Code` component (withastro#10251) chang changeset (withastro#10253) Removes morph animations when setting transition:animate=none (withastro#10247) ...
* main: [ci] format fix(withastro#8625): smooth scrolling in SPA mode on iOS (withastro#10235) [ci] release (withastro#10292) [ci] format finalize WIP API (withastro#10280) [ci] format fix(markdoc & mdx): Proxy crimes (withastro#10278) [ci] release (withastro#10286) fix(audits): Don't warn about loading on data URIs (withastro#10275) fix(node): Safely create requests (withastro#10285) [ci] release (withastro#10265) [ci] format fix(assets): Solidify Node endpoint (withastro#10284)
Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we're all in this file at the same time, so here are some suggestions from me to consider for the docs!
removing my block because the docs are here, being worked on!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@ematipico It doesn't look like my comments above have been addressed yet. |
Which ones? Sorry, it's becoming confusing 😅 I would be grateful if you can tell me what I have need to address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up Ema!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some suggestions where I think we can use more user-friendly language in the changeset. See what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs!
Changes
Add build.assetsPrefix is also Object.
I also think
build.assetsPrefix
is also Object is good.Previous PR: #9898
Testing
Add
packages/astro/test/astro-assets-prefix-mult-cdn.test.js
file for test add multiple cdn option.Docs
Docs add how to use build.assetsPrefix with object Record<string, string> type.
Docs PR: withastro/docs#7183