Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve login command #10258

Merged
merged 1 commit into from
Feb 29, 2024
Merged

improve login command #10258

merged 1 commit into from
Feb 29, 2024

Conversation

FredKSchott
Copy link
Member

Changes

  • Improves the login flow, fixing a bug for Brave users who were blocked from talking to localhost in the browser. Now, we redirect the user directly to localhost to pass the session token via query param.

Testing

  • N/A

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d0c3518

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

natemoo-re
natemoo-re approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@FredKSchott FredKSchott merged commit c2e7b98 into main Feb 29, 2024
4 checks passed
@FredKSchott FredKSchott deleted the db-link-1 branch February 29, 2024 05:26
peng added a commit to peng/astro that referenced this pull request Mar 4, 2024
@peng
Merge branch 'main' into add-multiple-cdn-v2
0600b34 
* main: (327 commits)
  [ci] format
  fix(node): listen on 0.0.0.0 if server.host is set to true (withastro#10282)
  [ci] format
  fix(dev): cosider `base` when special-casing `/_image` (withastro#10274)
  [ci] format
  update login flow to support Brave (withastro#10258)
  [ci] format
  improve link command (withastro#10257)
  Updates deprecated Node.js 16 github actions (withastro#10270)
  Fix Vitest check fail again (withastro#10266)
  [ci] format
  Adds auto completion of `astro:` events when adding or removing event listeners on `document` (withastro#10263)
  Update Vite to latest (withastro#10259)
  [ci] release (withastro#10236)
  [ci] format
  fix(i18n): localised index pages are overwritten (withastro#10250)
  fix: change strategy for route caching (withastro#10248)
  Fix TypeScript type definitions for `Code` component (withastro#10251)
  chang changeset (withastro#10253)
  Removes morph animations when setting transition:animate=none (withastro#10247)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @natemoo-re