Fix react dependencies to improve test reliability (#3673)

* Fix local react tests by unifying versions * Add missing dependencies to react tests * Add changeset * Fix lockfile Co-authored-by: Matthew Phillips <matthew@skypack.dev>
withastro · Jun 22, 2022 · ba5ad78 · ba5ad78
1 parent ef6282d
commit ba5ad78
Show file tree

Hide file tree

Showing 14 changed files with 1,245 additions and 1,203 deletions.
diff --git a/.changeset/tricky-items-reply.md b/.changeset/tricky-items-reply.md
@@ -0,0 +1,8 @@
+---
+'@example/docs': patch
+'astro': patch
+'@astrojs/deno': patch
+'@astrojs/netlify': patch
+---
+
+Fix react dependencies to improve test reliability
diff --git a/examples/docs/package.json b/examples/docs/package.json
@@ -14,8 +14,8 @@
     "@docsearch/react": "^3.1.0",
     "@types/react": "^17.0.45",
     "preact": "^10.7.3",
-    "react": "^17.0.2",
-    "react-dom": "^17.0.2"
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   },
   "devDependencies": {
     "@astrojs/preact": "^0.1.3",

diff --git a/packages/astro/test/fixtures/0-css/package.json b/packages/astro/test/fixtures/0-css/package.json
@@ -6,6 +6,8 @@
     "@astrojs/react": "workspace:*",
     "@astrojs/svelte": "workspace:*",
     "@astrojs/vue": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/astro-attrs/package.json b/packages/astro/test/fixtures/astro-attrs/package.json
@@ -4,6 +4,8 @@
   "private": true,
   "dependencies": {
     "@astrojs/react": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/astro-client-only/package.json b/packages/astro/test/fixtures/astro-client-only/package.json
@@ -5,6 +5,8 @@
   "dependencies": {
     "@astrojs/svelte": "workspace:*",
     "@astrojs/react": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/astro-dynamic/package.json b/packages/astro/test/fixtures/astro-dynamic/package.json
@@ -5,6 +5,8 @@
   "dependencies": {
     "@astrojs/react": "workspace:*",
     "@astrojs/svelte": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/astro-partial-html/package.json b/packages/astro/test/fixtures/astro-partial-html/package.json
@@ -4,6 +4,8 @@
   "private": true,
   "dependencies": {
     "@astrojs/react": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/error-react-spectrum/package.json b/packages/astro/test/fixtures/error-react-spectrum/package.json
@@ -6,7 +6,7 @@
     "@adobe/react-spectrum": "^3.18.0",
     "@astrojs/react": "workspace:*",
     "astro": "workspace:*",
-    "react": "^17.0.2",
-    "react-dom": "^17.0.2"
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/errors/package.json b/packages/astro/test/fixtures/errors/package.json
@@ -8,6 +8,8 @@
     "@astrojs/solid-js": "workspace:*",
     "@astrojs/svelte": "workspace:*",
     "@astrojs/vue": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/slots-react/package.json b/packages/astro/test/fixtures/slots-react/package.json
@@ -4,6 +4,8 @@
   "private": true,
   "dependencies": {
     "@astrojs/react": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/astro/test/fixtures/static-build-frameworks/package.json b/packages/astro/test/fixtures/static-build-frameworks/package.json
@@ -5,6 +5,8 @@
   "dependencies": {
     "@astrojs/react": "workspace:*",
     "@astrojs/preact": "workspace:*",
-    "astro": "workspace:*"
+    "astro": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/integrations/deno/test/fixtures/basics/package.json b/packages/integrations/deno/test/fixtures/basics/package.json
@@ -5,6 +5,8 @@
   "dependencies": {
     "astro": "workspace:*",
     "@astrojs/deno": "workspace:*",
-    "@astrojs/react": "workspace:*"
+    "@astrojs/react": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }
diff --git a/packages/integrations/netlify/test/edge-functions/fixtures/edge-basic/package.json b/packages/integrations/netlify/test/edge-functions/fixtures/edge-basic/package.json
@@ -5,6 +5,8 @@
   "dependencies": {
     "astro": "workspace:*",
     "@astrojs/react": "workspace:*",
-    "@astrojs/netlify": "workspace:*"
+    "@astrojs/netlify": "workspace:*",
+    "react": "^18.1.0",
+    "react-dom": "^18.1.0"
   }
 }