Fix react dependencies to improve test reliability #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: edbee3d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
Note: Failing smoke tests are being addressed in a different PR and are not related to my changes. |
|
If you rebase this should pass: #3674 |
|
As just discussed, I'll fix the lockfile later today. Putting this on hold until then! |
|
@hippotastic I got this, will fix and merge. |
|
Awesome, thanks a lot! |
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Fix local react tests by unifying versions * Add missing dependencies to react tests * Add changeset * Fix lockfile Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
react/react-domversion^17.0.2to the same version as all our other packages (^18.1.0). This fixes local test runs in our monorepo which were failing since commit f5afaf2.Testing
Docs