Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react dependencies to improve test reliability #3673

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

hippotastic
Copy link
Contributor

Changes

  • Brings our last two packages depending on react/react-dom version ^17.0.2 to the same version as all our other packages (^18.1.0). This fixes local test runs in our monorepo which were failing since commit f5afaf2.
  • Adds missing dependencies to all our react test fixtures.

Testing

  • Ran all tests locally.

Docs

  • Not a visible change.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: edbee3d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Jun 22, 2022
@hippotastic
Copy link
Contributor Author

Note: Failing smoke tests are being addressed in a different PR and are not related to my changes.

@matthewp
Copy link
Contributor

If you rebase this should pass: #3674

@hippotastic
Copy link
Contributor Author

As just discussed, I'll fix the lockfile later today. Putting this on hold until then!

@matthewp
Copy link
Contributor

@hippotastic I got this, will fix and merge.

@hippotastic
Copy link
Contributor Author

Awesome, thanks a lot!

@matthewp matthewp merged commit ba5ad78 into withastro:main Jun 22, 2022
@hippotastic hippotastic deleted the fix/unify-react-dependencies branch June 22, 2022 13:12
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix local react tests by unifying versions

* Add missing dependencies to react tests

* Add changeset

* Fix lockfile

Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants