Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove type EndpointOutput #83

Merged

Conversation

vasfvitor
Copy link
Contributor

@vasfvitor vasfvitor commented Dec 3, 2023

I notice this when playing with Astro v4.0.0-beta.4. I think this should only be an issue when Astro 4 is in. But as of now the tests still passes. I'd say it's to push this along when updating tests to Astro v4. I'll leave as a draft PR for reference.

This only happens when a test fixture is updated to v4

Now, I'm unsure just removing it is the solution. This change is based on the mentioned upstream Astro PR and from it, it seems that just removing is fine.

Changes

  • Removed type EndpointOutput

Testing

pnpm test on Windows.
image

Docs

It should not affect users


Thank you

Copy link

changeset-bot bot commented Dec 3, 2023

⚠️ No Changeset found

Latest commit: c4be800

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexanderniebuhr alexanderniebuhr marked this pull request as ready for review December 5, 2023 12:49
@github-actions github-actions bot removed the docs pr label Dec 5, 2023
@alexanderniebuhr alexanderniebuhr changed the title Remove type EndpointOutput chore: remove type EndpointOutput Dec 5, 2023
@alexanderniebuhr alexanderniebuhr merged commit 773ad32 into withastro:main Dec 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants