Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated features from Astro 3.0 #76

Closed
alexanderniebuhr opened this issue Nov 27, 2023 · 2 comments · Fixed by #86
Closed

Remove deprecated features from Astro 3.0 #76

alexanderniebuhr opened this issue Nov 27, 2023 · 2 comments · Fixed by #86
Assignees
@alexanderniebuhr

Comments

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 27, 2023 •
edited
Loading

We need to also make sure do check this repo for: withastro/astro#9168
@alexanderniebuhr alexanderniebuhr self-assigned this Nov 27, 2023
@vasfvitor
Copy link
Contributor

vasfvitor commented Dec 3, 2023 •
edited
Loading

I stumbled upon this: type EndpointOutput was removed.
withastro/astro@cdabf6e#diff-cec1de65bb8dd2f8330cb37fe3698afd66162bc0f311aa11e0b3dd573f6a2b9f

it seems that this does the trick

- import { type APIContext, type EndpointOutput } from 'astro';
+ import { type APIContext } from 'astro';
- Promise<EndpointOutput | Response>
+ Promise<Response>

Currently type EndpointOutput is utilized in Cloudflare adapter as lines above. After this change all 60 tests passes

@alexanderniebuhr
Copy link
Member Author

@vasfvitor would you like to open a PR with that fix?

@vasfvitor vasfvitor mentioned this issue Dec 3, 2023
Merged
@alexanderniebuhr alexanderniebuhr mentioned this issue Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderniebuhr alexanderniebuhr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cloudflare): remove deprecated build.split option withastro/adapters
2 participants
@alexanderniebuhr @vasfvitor