Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added imagesecrets, external mappings/requests, args, upd images #29

Closed
wants to merge 1 commit into from

Conversation

sigurdblueface
Copy link

Changelog:

  • added imagePullSecrets support
  • updated images & versions
  • added option to specify deployment args, because starting from 2.35.0.1 version WIREMOCK_OPTION env variable is deprecated
  • added options to mount responses & mappings as a map, in addition to files from chart itself. this is useful when you have something on top of helm chart: helmfile, argo, etc

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for WIREMOCK_OPTIONS was added in the Docker image, and #26 bundles the update. But I agree switching to flags might be better

DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
- Update image version and index
- Updated readme with instructions to use helm repository
- Updated notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Updated CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
@DanielFran DanielFran mentioned this pull request Jul 3, 2024
6 tasks
DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
@leeturner leeturner closed this in 53202e1 Jul 15, 2024
@charleyka
Copy link

added options to mount responses & mappings as a map, in addition to files from chart itself. this is useful when you have something on top of helm chart: helmfile, argo, etc

This feature doesn't seem to be supported even after #41
Do you have plan to add it in the future ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants