Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIREMOCK_OPTIONS env var is ignored #28

Closed
sigurdblueface opened this issue Sep 7, 2023 · 3 comments · Fixed by #41
Closed

WIREMOCK_OPTIONS env var is ignored #28

sigurdblueface opened this issue Sep 7, 2023 · 3 comments · Fixed by #41
Labels
bug Something isn't working

Comments

@sigurdblueface
Copy link

Proposal

WIREMOCK_OPTIONS env variable seem to have zero effect on actual application.

App starts listening on 8080 instead of 9021 configured in the variable and ignores all other settings also.

log:

port:                         8080
enable-browser-proxying:      false
disable-banner:               false
no-request-journal:           false
verbose:                      false

values:

WIREMOCK_OPTIONS: "--verbose,--port=9021,--max-request-journal=1000,--local-response-templating,--root-dir=/home/wiremock/storage"

Reproduction steps

install app, enjoy crashloop due to liveness pointing to 'incorrect' port

References

No response
@sigurdblueface sigurdblueface added the bug Something isn't working label Sep 7, 2023
@sigurdblueface
Copy link
Author

i see, it is deprecated https://github.com/holomekc/wiremock#breaking-change--23501
one should add args: section for container template

@sigurdblueface
Copy link
Author

please see PR #29

@gungorerhan
Copy link

please see PR #29

I also need these changes. It would be great if someone can review and merge changes.

DanielFran added a commit to DanielFran/helm-charts that referenced this issue Jul 3, 2024
@DanielFran
Changelog:
a6e77e5 
- Update image version and index
- Updated readme with instructions to use helm repository
- Updated notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Updated CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
@DanielFran DanielFran mentioned this issue Jul 3, 2024
Merged
6 tasks
DanielFran added a commit to DanielFran/helm-charts that referenced this issue Jul 3, 2024
@DanielFran
Changelog:
e061f00 
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
DanielFran added a commit to DanielFran/helm-charts that referenced this issue Jul 3, 2024
@DanielFran
Changelog:
e7deadd 
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support wiremock v3 DanielFran/helm-charts
2 participants
@gungorerhan @sigurdblueface