Only resend proposals once after external commit #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
approved these changes
Jun 24, 2024
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the backend somehow ends up with duplicate remove proposals, when an external commit is processed duplicates are now filtered out before resending them.
I still don't know the root cause for the existence of duplicate proposals (#4102 is an attempt at reproducing), but this PR should mitigate the consequence of such an occurrence.
There are no new tests here, because I don't know how to cause duplicate proposals to be stored (short of adding them manually in the test).
https://wearezeta.atlassian.net/browse/WPB-9210
Checklist
changelog.d