Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subconversation test #4102

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add subconversation test #4102

merged 3 commits into from
Jun 25, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jun 24, 2024

This PR stemmed from an unsuccessful attempt at reproducing the duplicate proposal issue. It contains a new test for subconversations.

https://wearezeta.atlassian.net/browse/WPB-9210

Checklist

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 24, 2024
@pcapriotti pcapriotti marked this pull request as ready for review June 24, 2024 11:20
@pcapriotti pcapriotti changed the title Duplicate proposals Add subconversation test Jun 24, 2024
@pcapriotti pcapriotti merged commit c798b58 into develop Jun 25, 2024
10 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/repro-proposal-dups branch June 25, 2024 15:11
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants