Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve html template for deeplink #4100

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Improve html template for deeplink #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5886867
Improve html template for deeplink
smatting Jun 20, 2024
5871192
changelog
smatting Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/deeplink-mobile-friendly
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make the deeplink page mobile-friendly
14 changes: 11 additions & 3 deletions charts/nginz/templates/conf/_deeplink.html.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,18 @@
(or search for "deeplink" on docs.wire.com)
for details on use of the deeplink*/}}
<html>
<head></head>
<body>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
</head>
<body style="font-size: 1.5em; font-family: sans">
<h4>Wire client setup</h4>
{{- if hasKey .Values.nginx_conf "deeplink" }}
<a href="wire://access/?config={{ .Values.nginx_conf.deeplink.endpoints.backendURL }}/deeplink.json">Click here for access</a>
<p>
<label>backend: <code>{{ .Values.nginx_conf.deeplink.endpoints.backendURL }}/deeplink.json</code></label>
</p>
<a href="wire://access/?config={{ .Values.nginx_conf.deeplink.endpoints.backendURL }}/deeplink.json">
<button >Configure client to use this backend</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it wouldn't be better to keep this as text link as one can easily copy them (right click and send to coworker...) 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It can still be bold and red and what-ever-you-like, of course 😃 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<marquee>Configure client to use this backend</marquee>

</a>
{{- else }}
No Deep Link.
{{- end }}
Expand Down
Loading