Improve html template for deeplink #4100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
|
Without this PR
With this PR: |
supersven
reviewed
Jun 20, 2024
| <label>backend: <code>{{ .Values.nginx_conf.deeplink.endpoints.backendURL }}/deeplink.json</code></label> | ||
| </p> | ||
| <a href="wire://access/?config={{ .Values.nginx_conf.deeplink.endpoints.backendURL }}/deeplink.json"> | ||
| <button >Configure client to use this backend</button> |
There was a problem hiding this comment.
I'm wondering if it wouldn't be better to keep this as text link as one can easily copy them (right click and send to coworker...) 🤔
There was a problem hiding this comment.
(It can still be bold and red and what-ever-you-like, of course 😃 )
There was a problem hiding this comment.
<marquee>Configure client to use this backend</marquee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the deeplink page mobile-friendly and generally more informative.
Checklist
changelog.d