Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2025

BugWPB-20193 [iOS] Calling UI moves down when minimized then maximized

This PR was automatically cherry-picked based on the following PR:

Original PR description:


Issue

iOS-after-call-UI-minimized

The call actions view moves outside of the bottom safe area after minimising and maximising the call view.

Causes

The call actions view is part of the CallingBottomSheetViewController which acts as a swipe-able sheet that only shows the call actions by default, and displays the participants list when the user swipes up. This mechanism relies on a constraint that offsets the position of the view.

The offset is based on the call actions view height constraint. When the offset is updated, the height constraint misses the height of the bottom safe area (it evaluates to 0 because the view hasn't been laid out yet).

In addition to this, the height constraint doesn't take into account the SecurityLevelView height, which can further lower the calculated offset.

Solution

  • Update the height constraint after viewDidLayoutSubviews() so that the bottom safe area height is factored in
  • Inform the CallingBottomSheetViewController it needs to update the offset when the call actions view height constraint changes
  • Include the SecurityLevelView height in the call actions view height constraint

Testing

  • Start / join a call in a classified / unclassified conversation (it needs to have the classification banner)
  • Minimise and maximise the call view

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe changed the title fix: calling actions view moves down - WPB-20193 fix: calling actions view moves down - WPB-20193 🍒 Sep 17, 2025
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-Henner merge conflicts to be fixed

@netbe netbe requested a review from David-Henner September 17, 2025 07:33
…tainerViewController/CallingActionsInfoViewController/CallingActionsInfoViewController.swift
Copy link
Contributor Author

github-actions bot commented Sep 23, 2025

Test Results

1 871 tests   1 844 ✅  2m 15s ⏱️
  299 suites     27 💤
    1 files        0 ❌

Results for commit 98ae1a4.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒 lgtm;)

@David-Henner David-Henner added this pull request to the merge queue Sep 23, 2025
Merged via the queue into develop with commit b9a7b6f Sep 23, 2025
9 checks passed
@David-Henner David-Henner deleted the fix/calling-actions-view-moves-down-WPB-20193-cherry-pick branch September 23, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants