-
Notifications
You must be signed in to change notification settings - Fork 24
fix: calling actions view moves down - WPB-20193 🍒 #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calling actions view moves down - WPB-20193 🍒 #3595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-Henner merge conflicts to be fixed
...tainerViewController/CallingActionsInfoViewController/CallingActionsInfoViewController.swift
Outdated
Show resolved
Hide resolved
…tainerViewController/CallingActionsInfoViewController/CallingActionsInfoViewController.swift
Test Results1 871 tests 1 844 ✅ 2m 15s ⏱️ Results for commit 98ae1a4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒 lgtm;)
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
The call actions view moves outside of the bottom safe area after minimising and maximising the call view.
Causes
The call actions view is part of the
CallingBottomSheetViewController
which acts as a swipe-able sheet that only shows the call actions by default, and displays the participants list when the user swipes up. This mechanism relies on a constraint that offsets the position of the view.The offset is based on the call actions view height constraint. When the offset is updated, the height constraint misses the height of the bottom safe area (it evaluates to 0 because the view hasn't been laid out yet).
In addition to this, the height constraint doesn't take into account the
SecurityLevelView
height, which can further lower the calculated offset.Solution
viewDidLayoutSubviews()
so that the bottom safe area height is factored inCallingBottomSheetViewController
it needs to update the offset when the call actions view height constraint changesSecurityLevelView
height in the call actions view height constraintTesting
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: