Skip to content

Conversation

David-Henner
Copy link
Contributor

@David-Henner David-Henner commented Sep 16, 2025

BugWPB-20193 [iOS] Calling UI moves down when minimized then maximized

Issue

iOS-after-call-UI-minimized

The call actions view moves outside of the bottom safe area after minimising and maximising the call view.

Causes

The call actions view is part of the CallingBottomSheetViewController which acts as a swipe-able sheet that only shows the call actions by default, and displays the participants list when the user swipes up. This mechanism relies on a constraint that offsets the position of the view.

The offset is based on the call actions view height constraint. When the offset is updated, the height constraint misses the height of the bottom safe area (it evaluates to 0 because the view hasn't been laid out yet).

In addition to this, the height constraint doesn't take into account the SecurityLevelView height, which can further lower the calculated offset.

Solution

  • Update the height constraint after viewDidLayoutSubviews() so that the bottom safe area height is factored in
  • Inform the CallingBottomSheetViewController it needs to update the offset when the call actions view height constraint changes
  • Include the SecurityLevelView height in the call actions view height constraint

Testing

  • Start / join a call in a classified / unclassified conversation (it needs to have the classification banner)
  • Minimise and maximise the call view

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@David-Henner David-Henner force-pushed the fix/calling-actions-view-moves-down-WPB-20193 branch from 36ea32b to abcdab4 Compare September 16, 2025 15:29
Copy link
Contributor

Test Results

    2 files      3 suites   2m 0s ⏱️
1 824 tests 1 797 ✅ 27 💤 0 ❌
1 834 runs  1 807 ✅ 27 💤 0 ❌

Results for commit abcdab4.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@David-Henner David-Henner merged commit fecb07d into release/cycle-3.120 Sep 17, 2025
10 checks passed
@David-Henner David-Henner deleted the fix/calling-actions-view-moves-down-WPB-20193 branch September 17, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants