fix: calling actions view moves down - WPB-20193 #3591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The call actions view moves outside of the bottom safe area after minimising and maximising the call view.
Causes
The call actions view is part of the
CallingBottomSheetViewController
which acts as a swipe-able sheet that only shows the call actions by default, and displays the participants list when the user swipes up. This mechanism relies on a constraint that offsets the position of the view.The offset is based on the call actions view height constraint. When the offset is updated, the height constraint misses the height of the bottom safe area (it evaluates to 0 because the view hasn't been laid out yet).
In addition to this, the height constraint doesn't take into account the
SecurityLevelView
height, which can further lower the calculated offset.Solution
viewDidLayoutSubviews()
so that the bottom safe area height is factored inCallingBottomSheetViewController
it needs to update the offset when the call actions view height constraint changesSecurityLevelView
height in the call actions view height constraintTesting
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: