fix: Some workers not running when persistent websocket is enabled (WPB-7213) #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
alexandreferris,
borichellow,
MohamadJaara,
vitorhugods and
saleniuk
and removed request for
a team
8 tasks
Test Results812 tests 812 ✅ 7m 35s ⏱️ Results for commit f85e09b. ♻️ This comment has been updated with latest results. |
alexandreferris
approved these changes
Mar 20, 2024
|
Build 3670 failed. |
MohamadJaara
requested changes
Mar 21, 2024
app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt
Outdated
Show resolved
Hide resolved
…vocationForSelfClient and featureFlagsSyncWorker asynchronously
…tent_ws_is_enabled
|
Build 3715 failed. |
…ent_ws_is_enabled' into workers_not_running_when_persistent_ws_is_enabled # Conflicts: # kalium
8 tasks
…tent_ws_is_enabled # Conflicts: # kalium
|
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
approved these changes
Mar 25, 2024
|
Build 3731 succeeded. The build produced the following APK's: |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
CertificateRevocationListCheckWorker, observeCertificateRevocationForSelfClient and featureFlagsSyncWorker are expected to run after every sync. But in case we have persistent web socket, the app does not perform sync which cause to not run those workers.
Solutions
Run those worker on every app launch in ON_RESUME lifecycle from in HomeScreen.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.