Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove crlcheckWorker and featureWorker from running in userSession (WPB-7213) #2682

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Needed for this PR
wireapp/wire-android#2803

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

…ion (WPB-7213) (#2672)

* fix: run crlCheckWorker and FeatureFlagsSyncWorker on every app launch

* chore: detekt

* chore: detekt
@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Mar 25, 2024
Copy link
Contributor Author

github-actions bot commented Mar 25, 2024

Test Results

3 012 tests  ±0   2 891 ✔️ ±0   2m 44s ⏱️ +13s
   524 suites ±0      121 💤 ±0 
   524 files   ±0          0 ±0 

Results for commit 21deb6a. ± Comparison against base commit f32ce53.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 25, 2024

Datadog Report

All test runs a222bcb 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2116 38 11.1s Link
kalium-jvm 0 0 0 2891 121 13m 27.06s Link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 58.75%. Comparing base (f32ce53) to head (21deb6a).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2682      +/-   ##
=============================================
- Coverage      58.77%   58.75%   -0.03%     
  Complexity         7        7              
=============================================
  Files           1201     1201              
  Lines          46824    46836      +12     
  Branches        4396     4396              
=============================================
- Hits           27523    27520       -3     
- Misses         17334    17348      +14     
- Partials        1967     1968       +1     
Files Coverage Δ
...ature/e2ei/CertificateRevocationListCheckWorker.kt 84.21% <ø> (ø)
...ic/feature/featureConfig/FeatureFlagsSyncWorker.kt 96.55% <ø> (ø)
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32ce53...21deb6a. Read the comment docs.

@ohassine ohassine added this pull request to the merge queue Mar 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2024
@ohassine ohassine added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit 99c099c Mar 25, 2024
17 checks passed
@ohassine ohassine deleted the workers_not_running_when_persistent_ws_is_enabled-cherry-pick branch March 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants