-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2690
fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2690
Conversation
Test Results2 808 tests - 208 2 722 ✔️ - 173 25s ⏱️ - 2m 21s Results for commit f6aeeef. ± Comparison against base commit 20edfe6. This pull request removes 3016 and adds 2808 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 86 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2690 +/- ##
===========================================
- Coverage 59.00% 58.88% -0.13%
===========================================
Files 1204 1205 +1
Lines 46761 46883 +122
Branches 4385 4397 +12
===========================================
+ Hits 27593 27607 +14
- Misses 17179 17286 +107
- Partials 1989 1990 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…disabled_rc-cherry-pick
Cherry pick from the original PR:
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepository.kt
logic/src/commonTest/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepositoryTest.kt
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Connections.sq
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/ConnectionDAO.kt
PR Submission Checklist for internal contributors
What's new in this PR?
Issues
When user is trying to ignore the Connection request from the user whose backend is unavailable - Error is displayed.
Igrnoring the ConnectionRequest should be available even in that case.
Causes (Optional)
It was not implemented (quit a tricky case that nobody think about)
Solutions
Update ConnectionRepository by adding a separate fun for ignoring the connection request.
In case of request is still marked as Ignored localy.