fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
borichellow
requested review from
Garzas and
yamilmedina
and removed request for
Garzas
borichellow
approved these changes
Apr 4, 2024
Test Results2 808 tests - 208 2 722 ✔️ - 173 25s ⏱️ - 2m 21s Results for commit f6aeeef. ± Comparison against base commit 20edfe6. This pull request removes 3016 and adds 2808 tests. Note that renamed tests count towards both.This pull request removes 121 skipped tests and adds 86 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2690 +/- ##
===========================================
- Coverage 59.00% 58.88% -0.13%
===========================================
Files 1204 1205 +1
Lines 46761 46883 +122
Branches 4385 4397 +12
===========================================
+ Hits 27593 27607 +14
- Misses 17179 17286 +107
- Partials 1989 1990 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Garzas
approved these changes
Apr 4, 2024
…disabled_rc-cherry-pick
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
borichellow
deleted the
fix/ignore_connection_request_on_backend_disabled_rc-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepository.kt
logic/src/commonTest/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepositoryTest.kt
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Connections.sq
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/ConnectionDAO.kt
PR Submission Checklist for internal contributors
What's new in this PR?
Issues
When user is trying to ignore the Connection request from the user whose backend is unavailable - Error is displayed.
Igrnoring the ConnectionRequest should be available even in that case.
Causes (Optional)
It was not implemented (quit a tricky case that nobody think about)
Solutions
Update ConnectionRepository by adding a separate fun for ignoring the connection request.
In case of request is still marked as Ignored localy.