fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
MohamadJaara,
Garzas and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Garzas
approved these changes
Mar 29, 2024
|
|
||
| override suspend fun updateConnectionStatus(userId: UserId, connectionState: ConnectionState): Either<CoreFailure, Connection> = | ||
| updateRemoteConnectionStatus(userId, connectionState).map { connectionDTO -> | ||
| val connectionStatus = connectionDTO.copy(status = connectionStatusMapper.toApiModel(connectionState)!!) |
There was a problem hiding this comment.
well basically there is checking for null in fun updateRemoteConnectionStatus that is called before it. So it's kinda safe
borichellow
deleted the
fix/ignore_connection_request_on_backend_disabled_rc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
What's new in this PR?
Issues
When user is trying to ignore the Connection request from the user whose backend is unavailable - Error is displayed.
Igrnoring the ConnectionRequest should be available even in that case.
Causes (Optional)
It was not implemented (quit a tricky case that nobody think about)
Solutions
Update ConnectionRepository by adding a separate fun for ignoring the connection request.
In case of
FederatedBackendFailure.FailedDomainsrequest is still marked as "Ignored" localy.