-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2687
fix: Ignore ConnectionRequest on backend disabled RC [WPB-7087] #2687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 Just one small question
|
||
override suspend fun updateConnectionStatus(userId: UserId, connectionState: ConnectionState): Either<CoreFailure, Connection> = | ||
updateRemoteConnectionStatus(userId, connectionState).map { connectionDTO -> | ||
val connectionStatus = connectionDTO.copy(status = connectionStatusMapper.toApiModel(connectionState)!!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we secure that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well basically there is checking for null in fun updateRemoteConnectionStatus
that is called before it. So it's kinda safe
PR Submission Checklist for internal contributors
What's new in this PR?
Issues
When user is trying to ignore the Connection request from the user whose backend is unavailable - Error is displayed.
Igrnoring the ConnectionRequest should be available even in that case.
Causes (Optional)
It was not implemented (quit a tricky case that nobody think about)
Solutions
Update ConnectionRepository by adding a separate fun for ignoring the connection request.
In case of
FederatedBackendFailure.FailedDomains
request is still marked as "Ignored" localy.