refactor: make sure user is not Blank when using ACMEApi #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* refactor: make sure user is not Blank when using ACMEApi * Update network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com> * detekt * fix * trigger CI fix test * fix test --------- Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
github-actions
bot
added
the
cherry-pick
saleniuk
approved these changes
Mar 13, 2024
MohamadJaara
approved these changes
Mar 13, 2024
github-actions
bot
added
🚨 Potential breaking changes
type: refactoring 🛠
👕 size: M
labels
Test Results2 333 tests - 649 2 282 ✔️ - 579 15s ⏱️ - 2m 21s Results for commit 26d09f7. ± Comparison against base commit dea98f1. This pull request removes 2982 and adds 2333 tests. Note that renamed tests count towards both.This pull request removes 121 skipped tests and adds 51 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2639 +/- ##
=============================================
- Coverage 58.75% 58.69% -0.07%
Complexity 7 7
=============================================
Files 1188 1188
Lines 46090 46146 +56
Branches 4348 4366 +18
=============================================
+ Hits 27080 27084 +4
- Misses 17069 17118 +49
- Partials 1941 1944 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MohamadJaara
deleted the
refactor/acme-api-called-with-blank-URL-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
in the logs i see sometimes requests to localhost from acme server and since the logs are obfuscated i was not able to know what is going on
Causes (Optional)
this can result of having a network request with empty string
Solutions
return error when this happen
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References