Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make sure user is not Blank when using ACMEApi #2637

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

in the logs i see sometimes requests to localhost from acme server and since the logs are obfuscated i was not able to know what is going on

Causes (Optional)

this can result of having a network request with empty string

Solutions

return error when this happen

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, then we can remove now @Suppress("EnforceSerializableFields") 🙌

MohamadJaara and others added 2 commits March 12, 2024 17:15
…/unbound/acme/ACMEResponse.kt

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
@MohamadJaara MohamadJaara enabled auto-merge (squash) March 12, 2024 16:32
Copy link
Contributor

github-actions bot commented Mar 12, 2024

Test Results

2 837 tests   2 708 ✔️  26s ⏱️
   485 suites     129 💤
   485 files           0

Results for commit ab886d8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 12, 2024

Datadog Report

Branch report: refactor/acme-api-called-with-blank-URL
Commit report: 1954b0a
Test service: kalium-jvm

✅ 0 Failed, 2830 Passed, 123 Skipped, 8m 55.05s Wall Time

fix test
@MohamadJaara MohamadJaara force-pushed the refactor/acme-api-called-with-blank-URL branch 2 times, most recently from 19a6e26 to 0a36e71 Compare March 13, 2024 01:49
@MohamadJaara MohamadJaara enabled auto-merge (squash) March 13, 2024 08:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.83505% with 70 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@982f616). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2637   +/-   ##
====================================================
  Coverage                     ?   58.33%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1177           
  Lines                        ?    46159           
  Branches                     ?     4383           
====================================================
  Hits                         ?    26928           
  Misses                       ?    17272           
  Partials                     ?     1959           
Files Coverage Δ
.../com/wire/kalium/logic/data/e2ei/E2EIRepository.kt 78.53% <50.00%> (ø)
...lium/network/api/base/unbound/acme/ACMEResponse.kt 41.79% <31.70%> (ø)
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 24.19% <24.07%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982f616...ab886d8. Read the comment docs.

@MohamadJaara MohamadJaara merged commit 7c7883f into release/candidate Mar 13, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the refactor/acme-api-called-with-blank-URL branch March 13, 2024 08:23
github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
* refactor: make sure user is not Blank when using ACMEApi

* Update network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>

* detekt

* fix

* trigger CI

fix test

* fix test

---------

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2024
* refactor: make sure user is not Blank when using ACMEApi

* Update network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt



* detekt

* fix

* trigger CI

fix test

* fix test

---------

Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants