-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make sure user is not Blank when using ACMEApi #2637
refactor: make sure user is not Blank when using ACMEApi #2637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, then we can remove now @Suppress("EnforceSerializableFields")
🙌
network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt
Outdated
Show resolved
Hide resolved
…/unbound/acme/ACMEResponse.kt Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Datadog ReportBranch report: ✅ 0 Failed, 2830 Passed, 123 Skipped, 8m 55.05s Wall Time |
fix test
19a6e26
to
0a36e71
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2637 +/- ##
====================================================
Coverage ? 58.33%
Complexity ? 7
====================================================
Files ? 1177
Lines ? 46159
Branches ? 4383
====================================================
Hits ? 26928
Misses ? 17272
Partials ? 1959
Continue to review full report in Codecov by Sentry.
|
* refactor: make sure user is not Blank when using ACMEApi * Update network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com> * detekt * fix * trigger CI fix test * fix test --------- Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
* refactor: make sure user is not Blank when using ACMEApi * Update network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEResponse.kt * detekt * fix * trigger CI fix test * fix test --------- Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com> Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
in the logs i see sometimes requests to localhost from acme server and since the logs are obfuscated i was not able to know what is going on
Causes (Optional)
this can result of having a network request with empty string
Solutions
return error when this happen
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.