Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop handling team member add/removed events #2273

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

team member join/removed events are not supported anymore by the server

Solutions

nuke the events

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Unit Test Results

   438 files   -   41     438 suites   - 41   19s ⏱️ - 2m 37s
2 474 tests  - 197  2 396 ✔️  - 171  78 💤  - 26  0 ±0 

Results for commit ff7672c. ± Comparison against base commit 7600fa8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 28, 2023

Datadog Report

All test runs f7852d3 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2396 78 5m 54.09s Link
kalium-jvm 0 0 0 2564 104 7m 13.05s Link

…ember-join-leave-events

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
#	logic/src/commonTest/kotlin/com/wire/kalium/logic/data/team/TeamRepositoryTest.kt
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Merging #2273 (ff7672c) into develop (7600fa8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2273      +/-   ##
=============================================
- Coverage      58.08%   58.06%   -0.02%     
  Complexity        21       21              
=============================================
  Files           1087     1087              
  Lines          41147    40990     -157     
  Branches        3808     3800       -8     
=============================================
- Hits           23901    23802      -99     
+ Misses         15618    15562      -56     
+ Partials        1628     1626       -2     
Files Coverage Δ
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt 79.38% <ø> (-0.85%) ⬇️
...in/com/wire/kalium/logic/data/event/EventMapper.kt 20.82% <ø> (+0.87%) ⬆️
.../com/wire/kalium/logic/data/team/TeamRepository.kt 90.12% <ø> (+2.00%) ⬆️
...re/kalium/logic/sync/receiver/TeamEventReceiver.kt 74.41% <100.00%> (+6.93%) ⬆️
...re/kalium/logic/sync/receiver/UserEventReceiver.kt 79.84% <ø> (ø)
...base/authenticated/notification/EventContentDTO.kt 54.72% <ø> (+1.71%) ⬆️
...re/kalium/persistence/dao/message/MessageEntity.kt 76.32% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7600fa8...ff7672c. Read the comment docs.

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, just a small question on an unfinished comment 😅

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 30, 2023
Merged via the queue into develop with commit e2f290b Nov 30, 2023
17 checks passed
@MohamadJaara MohamadJaara deleted the feat/remove-team-member-join-leave-events branch November 30, 2023 04:03
MohamadJaara added a commit that referenced this pull request Jan 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2024
* Revert "feat: stop handling team member add/removed events (#2273)"

This reverts commit e2f290b

* feat: handle member leave team event

* delete unneeded stuff

* detekt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants