refactor: retain user info after deleting and remove users from groups when deleted #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
MohamadJaara
requested review from
a team,
typfel,
vitorhugods,
mchenani,
Garzas and
ohassine
and removed request for
a team
# Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/UserEventReceiver.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/team/TeamRepositoryTest.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/user/UserRepositoryTest.kt
github-actions
bot
added
🚨 Potential breaking changes
👕 size: M
and removed
👕 size: S
labels
MohamadJaara
changed the title
Test Results2 307 tests - 367 2 300 ✔️ - 270 3m 54s ⏱️ + 1m 31s Results for commit 5789ae5. ± Comparison against base commit c2e46cd. This pull request removes 2674 and adds 2307 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 7 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
logic/src/commonTest/kotlin/com/wire/kalium/logic/sync/receiver/UserEventReceiverTest.kt
Outdated
Show resolved
Hide resolved
mchenani
approved these changes
Dec 4, 2023
alexandreferris
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
and all of the other values are null and we were updating the DB with this date which will overwrite any data we have locally (hint deleted team members are have their name deleted)
Solutions
only mark the user as deleted when and retain info
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.