Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) #2011

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 25, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR is part 2, and contains

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title feat: move mls specific endpoints to v5 (WPB-1124) feat: move mls specific endpoints to v5 and enable dev support (WPB-1124) Aug 25, 2023
@yamilmedina yamilmedina changed the title feat: move mls specific endpoints to v5 and enable dev support (WPB-1124) feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) Aug 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Unit Test Results

   428 files  +1     428 suites  +1   2m 31s ⏱️ +37s
2 326 tests ±0  2 228 ✔️ ±0  98 💤 ±0  0 ±0 

Results for commit c1cb3b3. ± Comparison against base commit 862daff.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 25, 2023

Datadog Report

All test runs a83813a 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1756 43 1m 15.03s Link
kalium-jvm 0 0 0 2228 98 10m 41s Link

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • You probably need to move updateSupportedProtocols in SelfAPIV4 to v5
  • in FeatureSupportImpl the required api version for isMLSSupported needs to be bumped to 5

@yamilmedina
Copy link
Contributor Author

Two things:

  • You probably need to move updateSupportedProtocols in SelfAPIV4 to v5
  • in FeatureSupportImpl the required api version for isMLSSupported needs to be bumped to 5

Thanks, i moved the isMLSSupported version to 5, but the first point, about SelfAPIV4, I don't see the implementation on the release/candidate 🤔

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/finalizev4-api-movemls-tov5@862daff). Click here to learn what that means.
The diff coverage is 64.22%.

@@                         Coverage Diff                         @@
##             feat/finalizev4-api-movemls-tov5    #2011   +/-   ##
===================================================================
  Coverage                                    ?   58.00%           
  Complexity                                  ?       24           
===================================================================
  Files                                       ?     1003           
  Lines                                       ?    37500           
  Branches                                    ?     3425           
===================================================================
  Hits                                        ?    21751           
  Misses                                      ?    14278           
  Partials                                    ?     1471           
Files Changed Coverage Δ
...re/kalium/logic/featureFlags/FeatureSupportImpl.kt 0.00% <0.00%> (ø)
...ium/network/api/base/authenticated/e2ei/E2EIApi.kt 0.00% <0.00%> (ø)
.../network/api/v0/authenticated/ConversationApiV0.kt 56.35% <0.00%> (ø)
...um/network/api/v0/authenticated/KeyPackageApiV0.kt 10.00% <0.00%> (ø)
.../network/api/v0/authenticated/MLSPublicKeyApiV0.kt 25.00% <0.00%> (ø)
.../network/api/v4/authenticated/ConversationApiV4.kt 46.15% <ø> (ø)
...etworkContainer/AuthenticatedNetworkContainerV4.kt 0.00% <0.00%> (ø)
...e/kalium/network/api/v5/authenticated/E2EIApiV5.kt 66.66% <63.15%> (ø)
.../network/api/v5/authenticated/ConversationApiV5.kt 70.96% <70.00%> (ø)
...um/network/api/v5/authenticated/KeyPackageApiV5.kt 75.00% <72.22%> (ø)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862daff...c1cb3b3. Read the comment docs.

@typfel
Copy link
Member

typfel commented Aug 25, 2023

Two things:

  • You probably need to move updateSupportedProtocols in SelfAPIV4 to v5
  • in FeatureSupportImpl the required api version for isMLSSupported needs to be bumped to 5

Thanks, i moved the isMLSSupported version to 5, but the first point, about SelfAPIV4, I don't see the implementation on the release/candidate 🤔

Ah maybe it's on the mls epic branch. All good then.

edit: yes, it's only exists on the epic branch

@yamilmedina yamilmedina merged commit a2b7c7a into feat/finalizev4-api-movemls-tov5 Aug 28, 2023
12 checks passed
@yamilmedina yamilmedina deleted the feat/movemls-tov5 branch August 28, 2023 08:40
yamilmedina added a commit that referenced this pull request Aug 29, 2023
…4) (#2001)

* feat: add v5 boilerplate code apis

* feat: pr comments

* feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011)

* feat: move conversation mls endpoints

* feat: move conversation mls endpoints

* chore: move tests

* chore: move tests

* chore: move tests

* chore: detekt

* chore: support v5 as dev

* chore: move e2e endpoints

* chore: move e2e endpoints

* feat: pr comments
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
…4) (#2001)

* feat: add v5 boilerplate code apis

* feat: pr comments

* feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011)

* feat: move conversation mls endpoints

* feat: move conversation mls endpoints

* chore: move tests

* chore: move tests

* chore: move tests

* chore: detekt

* chore: support v5 as dev

* chore: move e2e endpoints

* chore: move e2e endpoints

* feat: pr comments
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2023
…2016)

* feat: boilerplate to support development version api v5 pt.1 (WPB-1124) (#2001)

* feat: add v5 boilerplate code apis

* feat: pr comments

* feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011)

* feat: move conversation mls endpoints

* feat: move conversation mls endpoints

* chore: move tests

* chore: move tests

* chore: move tests

* chore: detekt

* chore: support v5 as dev

* chore: move e2e endpoints

* chore: move e2e endpoints

* feat: pr comments

* Empty-Commit

* chore: detekt

* chore: detekt

* chore: detekt

---------

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants