-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) #2011
feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) #2011
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- You probably need to move
updateSupportedProtocols
inSelfAPIV4
to v5 - in
FeatureSupportImpl
the required api version forisMLSSupported
needs to be bumped to 5
Thanks, i moved the |
Codecov Report
@@ Coverage Diff @@
## feat/finalizev4-api-movemls-tov5 #2011 +/- ##
===================================================================
Coverage ? 58.00%
Complexity ? 24
===================================================================
Files ? 1003
Lines ? 37500
Branches ? 3425
===================================================================
Hits ? 21751
Misses ? 14278
Partials ? 1471
Continue to review full report in Codecov by Sentry.
|
Ah maybe it's on the mls epic branch. All good then. edit: yes, it's only exists on the epic branch |
a2b7c7a
into
feat/finalizev4-api-movemls-tov5
…4) (#2001) * feat: add v5 boilerplate code apis * feat: pr comments * feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011) * feat: move conversation mls endpoints * feat: move conversation mls endpoints * chore: move tests * chore: move tests * chore: move tests * chore: detekt * chore: support v5 as dev * chore: move e2e endpoints * chore: move e2e endpoints * feat: pr comments
…4) (#2001) * feat: add v5 boilerplate code apis * feat: pr comments * feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011) * feat: move conversation mls endpoints * feat: move conversation mls endpoints * chore: move tests * chore: move tests * chore: move tests * chore: detekt * chore: support v5 as dev * chore: move e2e endpoints * chore: move e2e endpoints * feat: pr comments
…2016) * feat: boilerplate to support development version api v5 pt.1 (WPB-1124) (#2001) * feat: add v5 boilerplate code apis * feat: pr comments * feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011) * feat: move conversation mls endpoints * feat: move conversation mls endpoints * chore: move tests * chore: move tests * chore: move tests * chore: detekt * chore: support v5 as dev * chore: move e2e endpoints * chore: move e2e endpoints * feat: pr comments * Empty-Commit * chore: detekt * chore: detekt * chore: detekt --------- Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
This PR is part 2, and contains
Needs releases with:
feat: boilerplate to support development version api v5 pt.1 (WPB-1124) #2001
GitHub link to other pull request
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.