Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: boilerplate to support development version api v5 (WPB-1124) #2016

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2023

…4) (#2001)

* feat: add v5 boilerplate code apis

* feat: pr comments

* feat: move mls specific endpoints to v5 and enable dev support pt.2 (WPB-1124) (#2011)

* feat: move conversation mls endpoints

* feat: move conversation mls endpoints

* chore: move tests

* chore: move tests

* chore: move tests

* chore: detekt

* chore: support v5 as dev

* chore: move e2e endpoints

* chore: move e2e endpoints

* feat: pr comments
@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 29, 2023
@yamilmedina yamilmedina changed the title feat: boilerplate to support development version api v5 pt.1 (WPB-1124) feat: boilerplate to support development version api v5 (WPB-1124) Aug 29, 2023
@typfel
Copy link
Member

typfel commented Aug 29, 2023

@yamilmedina are you working on getting this mergeable? Would good to get into develop so I can rebase the MLS work on top of it.

@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 29, 2023

Unit Test Results

   353 files   -   75     353 suites   - 75   10s ⏱️ - 3m 2s
1 803 tests  - 527  1 760 ✔️  - 472  43 💤  - 55  0 ±0 

Results for commit 5c90090. ± Comparison against base commit ba5c7bf.

♻️ This comment has been updated with latest results.

@yamilmedina
Copy link
Contributor

@yamilmedina are you working on getting this mergeable? Would good to get into develop so I can rebase the MLS work on top of it.

Yup, I'm fixing some conflicts with the cert pinning that was introduced, but should be almost there :D

@yamilmedina yamilmedina requested review from typfel, mchenani, a team, yamilmedina, borichellow, vitorhugods and MohamadJaara and removed request for a team and yamilmedina August 29, 2023 13:37
@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 29, 2023

Datadog Report

All test runs 555d94e 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1760 43 1m 14.01s Link
kalium-jvm 0 0 0 2232 98 9m 57s Link

@yamilmedina yamilmedina added this pull request to the merge queue Aug 29, 2023
Merged via the queue into develop with commit 05d4b38 Aug 29, 2023
17 checks passed
@yamilmedina yamilmedina deleted the feat/finalizev4-api-movemls-tov5-cherry-pick branch August 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XXL type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants