Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover some missed classes of sync with unit test - PART 2 (WPB-3472) #1974

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Follow up PR of #1973 to increase sync unit test

Mainly covering ObserveSyncStateUseCase and ConversationEventReceiver with unit tests


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title test: cover some missed classes of sync with unit test (WPB-3472) test: cover some missed classes of sync with unit test - PART 2 (WPB-3472) Aug 10, 2023
@ohassine ohassine requested review from a team, typfel, gongracr, borichellow, mchenani and saleniuk and removed request for a team August 10, 2023 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Unit Test Results

   422 files  +  2     422 suites  +2   2m 37s ⏱️ +45s
2 266 tests +27  2 168 ✔️ +27  98 💤 ±0  0 ±0 

Results for commit bbf1add. ± Comparison against base commit 3893877.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #1974 (7167953) into develop (d826a6f) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #1974      +/-   ##
=============================================
+ Coverage      56.03%   56.26%   +0.22%     
  Complexity        49       49              
=============================================
  Files           1021     1021              
  Lines          37948    37946       -2     
  Branches        3451     3451              
=============================================
+ Hits           21266    21349      +83     
+ Misses         15244    15156      -88     
- Partials        1438     1441       +3     
Files Changed Coverage Δ
.../wire/kalium/logic/data/sync/SlowSyncRepository.kt 75.86% <ø> (+10.34%) ⬆️
...m/logic/sync/receiver/ConversationEventReceiver.kt 100.00% <100.00%> (+100.00%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d826a6f...7167953. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 10, 2023

Datadog Report

All test runs d3ae658 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1558 31 11.1s Link
kalium-jvm 0 0 0 2178 99 5m 7s Link

@ohassine ohassine added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 11, 2023
@vitorhugods vitorhugods added this pull request to the merge queue Aug 11, 2023
Merged via the queue into develop with commit f47c887 Aug 11, 2023
12 checks passed
@vitorhugods vitorhugods deleted the sync_test branch August 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants