test: cover some missed parts of sync with unit test - PART 1 (WPB-3471) #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
changed the title
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: chore 🧹
type: test 👷
and removed
type: chore 🧹
labels
Datadog ReportAll test runs ❄️ 2 Total Test Services: 0 Failed, 1 with New Flaky, 2 Passed Test Services
|
ohassine
requested review from
a team,
yamilmedina,
alexandreferris,
MohamadJaara,
vitorhugods and
Garzas
and removed request for
a team
alexandreferris
approved these changes
Aug 10, 2023
vitorhugods
approved these changes
Aug 10, 2023
Comment on lines
+28
to
+30
| internal interface SyncSelfUserUseCase { | ||
| suspend operator fun invoke(): Either<CoreFailure, Unit> | ||
| } |
There was a problem hiding this comment.
Nice catch making these internals.
These are so old that we didn't have this standard back then :D
yamilmedina
approved these changes
Aug 10, 2023
ohassine
changed the title
6 tasks
ohassine
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Some parts of slow sync are missing unit test
Solutions
Cover
RestartSlowSyncProcessForRecoveryUseCaseandSlowSyncWorkerwith testDependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.