Tags: willisplummer/react-testing-library
Tags
fix(TS): add explicit annotation to Query type (testing-library#260) <!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: Bug <!-- Why are these changes necessary? --> **Why**: The existing typescript definitions fail to compile with `--noImplicitAny` enabled. <!-- How were these changes implemented? --> **How**: I forked the project and tested that the updated declaration compiles correctly. <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation N/A - [ ] Tests N/A - [X] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
fix(TS): add queries typings (testing-library#259) <!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: Add typings for queries in RenderOptions <!-- Why are these changes necessary? --> **Why**: It's missing. Also in a project I need to add some custom queries. <!-- How were these changes implemented? --> **How**: <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation - [ ] Tests - [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments --> The implementation is trickier than I thought. Any comment is appreciated. Also `Query` and `Queries` should probably be declared in `dom-testing-library`. I can create another PR once the implementation of this PR is accepted.
fix(TS): make container optional in RenderOptions (testing-library#253) **What**: TS: make container optional in RenderOptions <!-- Why are these changes necessary? --> **Why**: Particularly useful if you're making a custom render with custom options. If you extend the type and call your custom render without the container but with the other options then you get a false error. <!-- How were these changes implemented? --> **How**: `?` <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation N/A - [ ] Tests N/A - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table N/A <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
fix: update dom-testing-library dependency (testing-library#240)
feat: add flushEffects to prepare for hooks (testing-library#223)
PreviousNext