Skip to content

Add ability to test component hydration #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

chrbala
Copy link
Contributor

@chrbala chrbala commented Dec 15, 2018

What: Add ability to test component hydration

Why: Hydration can be used for server side rendering. Hydration only attaches event listeners and does not change the props, even if a different tree is rendered. react-testing-library should allow testing of hydration for SSR.

How: A flag in render() that toggles hydration.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@kentcdodds
Copy link
Member

Thanks! Could you add some documentation for this?

@chrbala
Copy link
Contributor Author

chrbala commented Dec 16, 2018

Hi Kent! 👋 What are you looking for beyond what I added to the readme?

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't notice you had actually already documented this!

@kentcdodds kentcdodds merged commit 08731f2 into testing-library:master Dec 16, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
…options-clearer-example

docs: ✏️ improve clarity of example for selectOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants