-
Notifications
You must be signed in to change notification settings - Fork 407
Fix theme for Slack 3.2.0 #60
base: master
Are you sure you want to change the base?
Conversation
… on "new message" banner
- fixed channel browser, some hovering and button styles
Looks like the threads input text aren't following the theme. https://cl.ly/37210F1b0E3U |
@widget- any chance you could take a look at this? |
@widget- can we have this merged ? |
@widget- Hello! Is there any chance you might take a look at this? Thanks a lot! :) |
@Nockiro There are still a couple places in All Threads and the Thread Sidebar on the right where the theme is broken, even in the latest commit in this PR. Thanks so much for fixing pretty much everything, though. |
Until this is merged, I forked the repo and merged Nockiro's two fix branches. Edit: Or use Nockiro's master branch in the next post; he seems more likely to keep it up to date anyway. :) |
@SystemDisc I can't find any, if you could take a screenshot of the glitches, it would maybe help me to see them - thanks for reporting, though! |
@Nockiro thanks for all the fixes! Unfortunately I tried using the master branch but when opening Slack it just infinitely shows the loading screen and 'Connecting to Slack'. Anything I'm doing wrong? |
@Nockiro I'm using the most recent commit in this PR. Here's what I see: |
I'm supporting https://github.com/elv1n/slack-dark-mojave-theme to be up to date with slack updates |
Changed my CSS line to |
I've switched to using https://github.com/elv1n/slack-dark-mojave-theme. As of today, there's an issue with the "All Threads" view, but it seems a lot easier to use and seems to get updates more frequently - at least for now. |
Since the codes and workarounds in #48 do work but don't include the theme colors anymore, this should fix most of the broken areas taking the theme variables into account.