Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Chat box background is still staying in white v3.2.0 #62

Closed
khanhletv opened this issue Jul 27, 2018 · 36 comments
Closed

Chat box background is still staying in white v3.2.0 #62

khanhletv opened this issue Jul 27, 2018 · 36 comments

Comments

@khanhletv
Copy link

Hi there,

I have applied some sample color schema but the chat box background still stay in white.

Thanks and regards,

@khanhletv khanhletv reopened this Aug 1, 2018
@jhollowed
Copy link

jhollowed commented Aug 1, 2018

Currently experiencing the same issue :( Slack version 3.2.1 on Ubuntu 16.04

@MalPr0c3ss
Copy link

Same here...

Win 10 Pro x64
ver. 10.0.17134

@Blizzardo1
Copy link

I'm also experiencing this.

@intere
Copy link

intere commented Aug 2, 2018

@Nockiro has fixed this in this PR: https://github.com/widget-/slack-black-theme/pull/60

@khanhletv
Copy link
Author

Thank you, I will try and let you know once it was fixed.

@intere
Copy link

intere commented Aug 3, 2018

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

@khanhletv
Copy link
Author

@intere yep, it works perfectly. Thanks for helping me out and this issue should be closed for now.

@jhollowed
Copy link

jhollowed commented Sep 11, 2018

referencing the alternative css url given above by @intere had no change for me on Ubuntu 16.04

@zerodivisionerr
Copy link

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

Thank you so much! Verified working on MacOS Mojave, Slack version 3.3.3!

@mingrammer
Copy link

It works for me too

@josephtoles
Copy link

This fix works on Linux running Slack version 3.3.3.

@monkpit
Copy link

monkpit commented Jan 2, 2019

This fix makes all colors from the Jenkins bot turn to black. They used to be various colors based upon the status of the Jenkins job (Green for success, red for failed, etc)...
screen shot 2019-01-02 at 11 03 15 am

@Nockiro
Copy link

Nockiro commented Jan 2, 2019

Hi @monkpit,
I didn't continue with the pull request here as slack 3.3 needed other fixes and I didn't want to open a new pull request with the old one not merged yet.
Despite that, I continued to adjust the theme on my fork - including the mentioned colors, if you try https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css, the colors should work correctly.

@harveymonster
Copy link

Hi @Nockiro, I linked to the CSS on your fork and noticed that if you edit a message from within a thread, the textbox doesn't have the dark background.

image

@Nockiro
Copy link

Nockiro commented Jan 3, 2019

Hi @harveymonster,
thanks for the hint! Fixed it and gave it the same background the standard edit inputs have, the elevated background.

@mark-bixler
Copy link

Confirmed this works on Mojave, Slack 3.3.6.

If you're having issues on Mojave, verify the way you're editing your index.js & ssb-interop.js files.

I originally was using vscode to edit, copy and paste and didn't realize formatting was all jacked up.

I ended up using textmate to copy and paste css and it works great now!

@kyub
Copy link

kyub commented Jan 24, 2019

There is still a white box appearing at the top in All Unreads and All Threads.

slack_theme

@CliffWheadon
Copy link

@kyub That appears to be gone if you switch to using the most recent css from Nockiro's fork: https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css

@bjorkmeister
Copy link

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

This works on MacOS Mojave 10.14.2. Thanks.

@harveymonster
Copy link

Hey @Nockiro, I'm assuming slack has made a layout change around threads recently because the reply box in a thread is no longer dark.
image

Also, I noticed that if you are a part of a slack team where the admin has limited who can post to the "general" channel the message that replaces the textbox to type a message is still light.
image

@Nockiro
Copy link

Nockiro commented Jan 30, 2019

Hi @harveymonster,
thanks for noticing! Fixed both (and with it a few other things in the process).

@dchaid
Copy link

dchaid commented Jan 31, 2019

Feeling dumb. I'm using https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css but my theme is still very, very white.

ssb-interop-dchaid.txt

@Nockiro
Copy link

Nockiro commented Feb 1, 2019

In the file you attached it seems like you added the code somehow nested and twice? That impacts the result, you have to use the code specified in the Readme from line 100 in your case.

@edswangren
Copy link

edswangren commented Feb 5, 2019

Not working at all for me, Win10 slack 3.3.6

The master version has the white message area and it seems like neither of the new css links in this thread are being loaded.

index.txt
ssb-interop.txt

@jhollowed
Copy link

I've tried many times over the past few months, and none of the solutions here work for me either on Ubuntu 16.04, Slack 3.3.3. Why can't this finally be fixed in master? It literally makes the dark theme not dark

@iniquityx2
Copy link

Confirmed this works on Slack 3.3.7 64 windows 10

@edswangren
Copy link

Working for me after moving to 3.3.7 as well. No idea.

@mB-PiBox
Copy link

Not able to get this to work on Slack 3.3.8

  • List of "Chats" far left is black; but channel list and chat are not effected by styling.

@iniquityx2
Copy link

Worked for me just fine on 3.3.8 - Windows 10 x64

@bison92
Copy link

bison92 commented Mar 25, 2019

@iniquityx2 please tell us what you had to do ??

@iniquityx2
Copy link

nothing other than going into the new folder location \slack\app-3.3.8\resources\app.asar.unpacked\src\static\index.js and and ssb-interop.js and inserting the section from the main help on this repo.

I did of course have to put in the modified css https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css

This has worked on two different windows 10 x64 machines without issue

@Snowflake6
Copy link

Odd. This worked fine for me on 3.3.7, but on 3.3.8 i'm back to getting a white message area with black text. Both with the stock section from the readme.md and with the modified css that @iniquityx2 mentions. Same result.

@Snowflake6
Copy link

Gah. And now, after four re-starts, it starts working. No change to the code. I guess there's some cache-ing going on somewhere?

@iniquityx2
Copy link

Glad it started working for you all. Was starting to wonder if I should post my configs.

I didn't experience the delay on getting it to work though there was about 5 seconds where it was the normal theme and then it switched over

@Snowflake6
Copy link

And now Windows is offering an update, so maybe it was running slow for some reason as well while the update was downloading. In any case, seems to be working after a short delay.

@iniquityx2
Copy link

Still working on Slack 3.40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests