Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *sklearn* from env YAML already provided by *scikit-learn* #244

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

paulmenzel
Copy link
Contributor

No description provided.

Putting the packages from `souporcell_env.yaml` in `requirements.txt` and
installing them with Pip results in:

    $ pip3 install -r requirements.txt
    […]
    Collecting sklearn (from -r requirements.txt (line 63))
      Downloading sklearn-0.0.post12.tar.gz (2.6 kB)
      Installing build dependencies ... done
      Getting requirements to build wheel ... error
      error: subprocess-exited-with-error

      × Getting requirements to build wheel did not run successfully.
      │ exit code: 1
      ╰─> [15 lines of output]
          The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
          rather than 'sklearn' for pip commands.

          Here is how to fix this error in the main use cases:
          - use 'pip install scikit-learn' rather than 'pip install sklearn'
          - replace 'sklearn' by 'scikit-learn' in your pip requirements files
            (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
          - if the 'sklearn' package is used by one of your dependencies,
            it would be great if you take some time to track which package uses
            'sklearn' instead of 'scikit-learn' and report it to their issue tracker
          - as a last resort, set the environment variable
            SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error

          More information is available at
          https://github.com/scikit-learn/sklearn-pypi-package
          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: subprocess-exited-with-error

As *scikit-learn* is already listed, remove *sklearn*.
@wheaton5
Copy link
Owner

Im open to this, but is there a bug it fixes? Otherwise I need to do a lot of testing.

@paulmenzel
Copy link
Contributor Author

See the commit message.

@wheaton5 wheaton5 merged commit 08d3c2e into wheaton5:master Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants