-
Notifications
You must be signed in to change notification settings - Fork 308
Introduce moveBefore()
state-preserving atomic move API
#1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
5920e1c
Initial atomic move skeleton
domfarolino 442ef6d
Most of the `MutationObserver` integration
domfarolino 1c8f74f
Remove mutation events flag references
domfarolino bc1a466
Populate the `MutationRecord`
domfarolino 4030e9a
Fix punctuation
domfarolino 8d41e6a
Remove trailing whitespace
domfarolino 588e62d
`<span>` -> `<a>` plus fix punctuation error
domfarolino 2b8cf63
Camel case
domfarolino 7b742c7
Throw an exception on failure
domfarolino 7039d3b
Introduce move primitive + moving steps hook/extension
domfarolino b17f357
Remove changes to insertion primitive
domfarolino ef2f986
Revert document flag and mutation record changes
domfarolino 0a81382
Fix mutation record callsites
domfarolino 7fda266
Fix wrapping
domfarolino 1101073
Remove suppress observers flag
domfarolino b43c8fc
Custom element integration
domfarolino ba0638d
Update live ranges and NodeIterators properly; do not call the remove…
domfarolino 53c9142
Correct removal bookkeeping
domfarolino 25d501e
Moving steps prose
domfarolino a940827
Tighten up pre-move checks
domfarolino 8ded562
Assert -> throw condition
domfarolino dbbde9e
Move conditions into pre-move validity
domfarolino e28936a
Fix `<old>`
domfarolino 60076c9
Ordering and format
domfarolino b8ac7bd
Fix live range updating logic
domfarolino ff5f3dd
Document `move` primitive in Range note
domfarolino 707f3f6
Enable moves in a connected `ShadowRoot` `DocumentFragment` node
domfarolino 863f481
Do not explicitly rethrow
domfarolino c8822cd
Do not do special range handling
domfarolino f2ad3df
Support both connected->connected and disconnected->disconnected
domfarolino 6fe0a6e
Whitespace and formatting
domfarolino e2e7566
Factor our live range pre-removal steps
domfarolino 2a623d5
newParent, newPreviousSibling, and count
domfarolino a820a74
Only queue connectedMoveCallback if connected
domfarolino f23c498
Revert random editorial change
domfarolino 21d0da3
Remove newline
domfarolino 12259fb
Remove manual custom element upgrade
domfarolino 16178bb
Compare node documents instead of shadow-including roots
domfarolino cb0c91c
Align pre-move and pre-insertion conditions
domfarolino ca88e23
Add document-is-parent pre-move conditions
domfarolino 358cc43
Remove unnecessary checks now that we have root checks
domfarolino 90d4f45
Live range rename
domfarolino 2eb22d3
Empty arguments
domfarolino 641d6a6
Update dom.bs
domfarolino 26bd858
Update dom.bs
domfarolino 5fb8d3a
Remove run these steps
domfarolino 71736d9
Move to ParentNode, simplify pre-move conditions, add web developer box
domfarolino f321247
nits
annevk 53ce472
nit
annevk 4822fd7
actually, pre-removing here is better
annevk 1d49fc5
Make moveBefore() return undefined
domfarolino 937f22e
Fold more into the move algorithm
domfarolino 1e183c6
Document for reference, and this->newParent
domfarolino 5ae3cde
Update moving steps link to be consistent with other extension hooks,…
domfarolino a454656
Fire slotchange events on the removal and insertion during moveBefore
domfarolino 71a3c38
Remove incorrect `data-x` and `span`
domfarolino 53409b9
Wrapping
domfarolino 1f60b93
Add missing slot assignment steps
domfarolino 01b7634
Add missing li, even though it is missing from the place where I copi…
domfarolino 9270da7
Fix open paragraph after amend
domfarolino bfbcfd9
Address Anne review
domfarolino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.