Skip to content

Introduce moveBefore() state-preserving atomic move API #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
Mar 7, 2025
Merged

Introduce moveBefore() state-preserving atomic move API #1307

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
5920e1c
Initial atomic move skeleton
domfarolino Aug 19, 2024
442ef6d
Most of the `MutationObserver` integration
domfarolino Aug 26, 2024
1c8f74f
Remove mutation events flag references
domfarolino Aug 26, 2024
bc1a466
Populate the `MutationRecord`
domfarolino Aug 26, 2024
4030e9a
Fix punctuation
domfarolino Aug 26, 2024
8d41e6a
Remove trailing whitespace
domfarolino Aug 26, 2024
588e62d
`<span>` -> `<a>` plus fix punctuation error
domfarolino Aug 27, 2024
2b8cf63
Camel case
domfarolino Aug 27, 2024
7b742c7
Throw an exception on failure
domfarolino Sep 24, 2024
7039d3b
Introduce move primitive + moving steps hook/extension
domfarolino Sep 30, 2024
b17f357
Remove changes to insertion primitive
domfarolino Oct 10, 2024
ef2f986
Revert document flag and mutation record changes
domfarolino Oct 10, 2024
0a81382
Fix mutation record callsites
domfarolino Oct 10, 2024
7fda266
Fix wrapping
domfarolino Oct 10, 2024
1101073
Remove suppress observers flag
domfarolino Oct 10, 2024
b43c8fc
Custom element integration
domfarolino Oct 10, 2024
ba0638d
Update live ranges and NodeIterators properly; do not call the remove…
domfarolino Oct 10, 2024
53c9142
Correct removal bookkeeping
domfarolino Oct 10, 2024
25d501e
Moving steps prose
domfarolino Oct 15, 2024
a940827
Tighten up pre-move checks
domfarolino Oct 15, 2024
8ded562
Assert -> throw condition
domfarolino Oct 15, 2024
dbbde9e
Move conditions into pre-move validity
domfarolino Oct 15, 2024
e28936a
Fix `<old>`
domfarolino Oct 15, 2024
60076c9
Ordering and format
domfarolino Oct 16, 2024
b8ac7bd
Fix live range updating logic
domfarolino Nov 7, 2024
ff5f3dd
Document `move` primitive in Range note
domfarolino Nov 7, 2024
707f3f6
Enable moves in a connected `ShadowRoot` `DocumentFragment` node
domfarolino Nov 11, 2024
863f481
Do not explicitly rethrow
domfarolino Nov 13, 2024
c8822cd
Do not do special range handling
domfarolino Nov 19, 2024
f2ad3df
Support both connected->connected and disconnected->disconnected
domfarolino Nov 20, 2024
6fe0a6e
Whitespace and formatting
domfarolino Nov 20, 2024
e2e7566
Factor our live range pre-removal steps
domfarolino Nov 27, 2024
2a623d5
newParent, newPreviousSibling, and count
domfarolino Nov 27, 2024
a820a74
Only queue connectedMoveCallback if connected
domfarolino Nov 27, 2024
f23c498
Revert random editorial change
domfarolino Nov 27, 2024
21d0da3
Remove newline
domfarolino Nov 27, 2024
12259fb
Remove manual custom element upgrade
domfarolino Nov 27, 2024
16178bb
Compare node documents instead of shadow-including roots
domfarolino Dec 9, 2024
cb0c91c
Align pre-move and pre-insertion conditions
domfarolino Dec 10, 2024
ca88e23
Add document-is-parent pre-move conditions
domfarolino Dec 10, 2024
358cc43
Remove unnecessary checks now that we have root checks
domfarolino Dec 12, 2024
90d4f45
Live range rename
domfarolino Dec 12, 2024
2eb22d3
Empty arguments
domfarolino Dec 12, 2024
641d6a6
Update dom.bs
domfarolino Dec 12, 2024
26bd858
Update dom.bs
domfarolino Dec 12, 2024
5fb8d3a
Remove run these steps
domfarolino Dec 12, 2024
71736d9
Move to ParentNode, simplify pre-move conditions, add web developer box
domfarolino Dec 12, 2024
f321247
nits
annevk Dec 13, 2024
53ce472
nit
annevk Dec 13, 2024
4822fd7
actually, pre-removing here is better
annevk Dec 13, 2024
1d49fc5
Make moveBefore() return undefined
domfarolino Dec 16, 2024
937f22e
Fold more into the move algorithm
domfarolino Dec 17, 2024
1e183c6
Document for reference, and this->newParent
domfarolino Dec 17, 2024
5ae3cde
Update moving steps link to be consistent with other extension hooks,…
domfarolino Dec 17, 2024
a454656
Fire slotchange events on the removal and insertion during moveBefore
domfarolino Dec 20, 2024
71a3c38
Remove incorrect `data-x` and `span`
domfarolino Jan 14, 2025
53409b9
Wrapping
domfarolino Jan 14, 2025
1f60b93
Add missing slot assignment steps
domfarolino Feb 25, 2025
01b7634
Add missing li, even though it is missing from the place where I copi…
domfarolino Feb 25, 2025
9270da7
Fix open paragraph after amend
domfarolino Feb 25, 2025
bfbcfd9
Address Anne review
domfarolino Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update moving steps link to be consistent with other extension hooks,… 
… and to what HTML expects
  • Loading branch information
@domfarolino
domfarolino committed Feb 25, 2025
commit 5ae3cde315885bac6cd89a4bd787e40ce3caf847
2 changes: 1 addition & 1 deletion dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2882,7 +2882,7 @@ before a <var>child</var>, with an optional <i>suppress observers flag</i>, run


<p><a lt="Other applicable specifications">Specifications</a> may define <dfn export
id=concept-moving-steps-ext>moving steps</dfn> for all or some <a for=/>nodes</a>. The algorithm is
id=concept-node-move-ext>moving steps</dfn> for all or some <a for=/>nodes</a>. The algorithm is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DOM standard doesn't wrap on all spaces. Phrasing-level elements need to be kept on a single line. (This applies several times in this PR.)

It also seems okay to drop the explicit ID here as we stopped doing those.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this instance, after finishing rewrapping this paragraph, no more jumped out at me. Maybe you have others in mind further down.

It also seems okay to drop the explicit ID here as we stopped doing those.

Yeah I realize it isn't necessary, however I liked the formatting of concept-node-move-ext since it perfectly matches the other primitives that HTML links to, so it seemed nice for link consistency: https://github.com/whatwg/html/pull/10657/files#diff-41cf6794ba4200b839c53531555f0f3998df4cbb01a4d5cb0b94e3ca5e23947dR3290-R3291. If you want to remove it, feel free, just remember to update the HTML PR. Otherwise, I'd slightly slightly prefer keeping as-is.

passed a <a for=/>node</a> <var ignore>movedNode</var>, and a <a for=/>node</a>-or-null <var
ignore>oldParent</var> as indicated in the <a for=/>move</a> algorithm below. Like the <span
data-x="concept-insertion-steps-ext">insertion steps</span>, these steps must not modify the
Expand Down