Skip to content

Conversation

@j0mc
Copy link
Contributor

@j0mc j0mc commented Dec 5, 2024

Overview

On #83, the size of the logo in the header was changed, but this should have been included in the branding styles for the specific project, since this MFE is shared between multiple projects.

This changes the CSS rule for the header logo height back to 32px, and project specific customizations will be made to the associated branding repo.

Checklist

⚠️ Please make sure to fill this checklist before asking for reviews.

  • Code is correctly formatted and linted
  • Unit tests are updated and are passing
  • PR title follows conventional commits:
    i.e. feat(CUR-###): Feature title
  • PR Title aligns to Semantic-Release supported prefixes (NOTE: prefixes are case sensitive, keep lower-case):
 feat() - Feature (0.X.0)
 fix() - Patch (0.0.X)
 docs() - Patch (0.0.X), will only scope to README changes
 refactor() - Patch (0.0.X)
 revert() - Patch (0.0.X)
 style() - Patch (0.0.X)
  • Check for unused files
  • Check work before asking for reviewers
  • Fix any linting errors
  • SECURITY: No secrets where commited to the repo
  • COMPLIANCE: Commited code is not propietary and adheres to Open Source licensing

@j0mc j0mc requested a review from rodmgwgu December 5, 2024 20:48
@j0mc j0mc self-assigned this Dec 5, 2024
@j0mc j0mc merged commit b25a3fa into palm.master Dec 5, 2024
2 checks passed
@j0mc j0mc deleted the fix/header_logo_size_palm branch December 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants