Skip to content

Conversation

@j0mc
Copy link
Contributor

@j0mc j0mc commented Nov 2, 2024

Overview

This PR adds an optional link from the header logo to a configurable dashboard URL.
It also adds a configuration option to override the default links in the footer (Privacy Policy, Terms of Service, and Honor Code)

Test Steps

  • Set following configuration options in .env.private:
DISABLE_APP_FOOTER=false
DISABLE_DESKTOP_HEADER=false
DISABLE_HEADER_LOGO=false
FOOTER_LINK_MAP='[{"label": "Test Link", "url": "https://wgu.edu/", "id": 1}]'
ENABLE_DASHBOARD_RETURN_LINK=true
DASHBOARD_BASE_URL='https://academy.test'

Checklist

⚠️ Please make sure to fill this checklist before asking for reviews.

  • Code is correctly formatted and linted
  • Unit tests are updated and are passing
  • PR title follows conventional commits:
    i.e. feat(CUR-###): Feature title
  • PR Title aligns to Semantic-Release supported prefixes (NOTE: prefixes are case sensitive, keep lower-case):
 feat() - Feature (0.X.0)
 fix() - Patch (0.0.X)
 docs() - Patch (0.0.X), will only scope to README changes
 refactor() - Patch (0.0.X)
 revert() - Patch (0.0.X)
 style() - Patch (0.0.X)
  • Check for unused files
  • Check work before asking for reviewers
  • Fix any linting errors
  • SECURITY: No secrets where committed to the repo
  • COMPLIANCE: Committed code is not proprietary and adheres to Open Source licensing

j0mc added 4 commits November 1, 2024 16:18
    This modifies the header in the logo to link back to the main
    frontend, and configuration options, to enable the header link and
    set the base URL for the main frontend (DASHBOARD_BASE_URL)
	This adds a new configuration option FOOTER_LINK_MAP which
	overrides the default set of links in the footer. It's set as a
	json blob in the same format of the existing link map.
Copy link
Collaborator

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants