Skip to content

feat: Updated core library to match reqs for Palm #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
holaontiveros wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: Updated core library to match reqs for Palm #82

holaontiveros wants to merge 12 commits into from

Conversation

@holaontiveros
Copy link

@holaontiveros holaontiveros commented Jul 1, 2024

Overview

Release for Palm compatible version

Checklist

⚠️ Please make sure to fill this checklist before asking for reviews.

  • Code is correctly formatted and linted
  • Unit tests are updated and are passing
  • PR title follows conventional commits:
    i.e. feat(CUR-###): Feature title
  • PR Title aligns to Semantic-Release supported prefixes (NOTE: prefixes are case sensitive, keep lower-case):
 feat() - Feature (0.X.0)
 fix() - Patch (0.0.X)
 docs() - Patch (0.0.X), will only scope to README changes
 refactor() - Patch (0.0.X)
 revert() - Patch (0.0.X)
 style() - Patch (0.0.X)
  • Check for unused files
  • Check work before asking for reviewers
  • Fix any linting errors
  • SECURITY: No secrets where commited to the repo
  • COMPLIANCE: Commited code is not propietary and adheres to Open Source licensing

boonehm
boonehm previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@boonehm boonehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CourtneyMayberry
CourtneyMayberry previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@CourtneyMayberry CourtneyMayberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

j0mc added 7 commits November 21, 2024 15:33
@j0mc
Update pendo IIFE handling to evaluate configured IIFE
e3a42aa 
The pendo feature now evaluates the IIFE passed in via the MFE
configuration, and passes it two arguments, first is the base URL of the
lms in `lmsUrl`, and the second is the username in `username`.
Note that no error handling is provided for the IIFE, any exceptions
within the IIFE will be passed up to the browser. This assists in
debugging issues with the IIFE but risks causing errors for end users in
the MFE if the IIFE does not catch exceptions.
@j0mc
Fix username retrieval in pendoHelperCustom
f6fe6eb
@j0mc
Add dashboard return link to the logo in the header
63903ba 
    This modifies the header in the logo to link back to the main
    frontend, and configuration options, to enable the header link and
    set the base URL for the main frontend (DASHBOARD_BASE_URL)
@j0mc
Add configurable footer links with FOOTER_LINK_MAP
72bf1ff 
	This adds a new configuration option FOOTER_LINK_MAP which
	overrides the default set of links in the footer. It's set as a
	json blob in the same format of the existing link map.
@j0mc
Set logo height and default options for academy development
d8fca4a
@j0mc
Add tests
0271b9a
@j0mc
Move footer links config retrieval into render function
4b40978
@j0mc j0mc dismissed stale reviews from CourtneyMayberry and boonehm via 4b40978 November 22, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boonehm boonehm boonehm left review comments

@CourtneyMayberry CourtneyMayberry CourtneyMayberry left review comments

@rodmgwgu rodmgwgu Awaiting requested review from rodmgwgu

@AngelRicardezWGU AngelRicardezWGU Awaiting requested review from AngelRicardezWGU

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@holaontiveros @boonehm @CourtneyMayberry @j0mc