Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ssr again #52

Merged
merged 9 commits into from
Apr 4, 2023
Merged

fix ssr again #52

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
28c66f6
Update utils.js
shiyiya Apr 4, 2023
68a77ac
Update canvas.js
shiyiya Apr 4, 2023
2e82bfc
Update utils.js
shiyiya Apr 4, 2023
47becb4
Update canvas.js
shiyiya Apr 4, 2023
331f615
fix lint
shiyiya Apr 4, 2023
890a823
Update canvas.js
shiyiya Apr 4, 2023
585d50e
Update utils.js
shiyiya Apr 4, 2023
549f2d2
Update utils.js
shiyiya Apr 4, 2023
6b89bec
restore unrelated codes
weizhenye Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/engine/canvas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const dpr = window.devicePixelRatio || 1;
const dpr = typeof window !== 'undefined' && window.devicePixelRatio || 1;

export var canvasHeightCache = Object.create(null);

Expand Down
26 changes: 18 additions & 8 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,25 @@
export /* istanbul ignore next */ var raf =
window.requestAnimationFrame ||
window.mozRequestAnimationFrame ||
window.webkitRequestAnimationFrame ||
export var /* istanbul ignore next */ raf =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行别改

(
typeof window !== 'undefined' &&
(
window.requestAnimationFrame ||
window.mozRequestAnimationFrame ||
window.webkitRequestAnimationFrame
)
) ||
function(cb) {
return setTimeout(cb, 50 / 3);
};

export /* istanbul ignore next */ var caf =
window.cancelAnimationFrame ||
window.mozCancelAnimationFrame ||
window.webkitCancelAnimationFrame ||
export var /* istanbul ignore next */ caf =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太明白你的意思 你可以改直接修改pr内容的

(
typeof window !== 'undefined' &&
(
window.cancelAnimationFrame ||
window.mozCancelAnimationFrame ||
window.webkitCancelAnimationFrame
)
) ||
clearTimeout;

export function binsearch(arr, prop, key) {
Expand Down