fix ssr again #52
Merged
fix ssr again #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizhenye
requested changes
Apr 4, 2023
src/engine/canvas.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const dpr = window.devicePixelRatio || 1; | |||
| const dpr = typeof window !== undefined && window.devicePixelRatio || 1; | |||
src/utils.js
Outdated
| window.requestAnimationFrame || | ||
| window.mozRequestAnimationFrame || | ||
| window.webkitRequestAnimationFrame || | ||
| (typeof window !== undefined && |
There was a problem hiding this comment.
格式，下同
var raf =
(
typeof window !== 'undefined' &&
(
window.requestAnimationFrame ||
window.mozRequestAnimationFrame ||
window.webkitRequestAnimationFrame
)
) ||
function(cb) {
return setTimeout(cb, 50 / 3);
};
weizhenye
requested changes
Apr 4, 2023
src/utils.js
Outdated
| window.requestAnimationFrame || | ||
| window.mozRequestAnimationFrame || | ||
| window.webkitRequestAnimationFrame || | ||
| export var /* istanbul ignore next */ raf = |
src/utils.js
Outdated
| window.cancelAnimationFrame || | ||
| window.mozCancelAnimationFrame || | ||
| window.webkitCancelAnimationFrame || | ||
| export var /* istanbul ignore next */ caf = |
There was a problem hiding this comment.
不太明白你的意思 你可以改直接修改pr内容的
|
@weizhenye 看起来还有地方执行了
|
|
我还没发版本，你确定引用的是修改后的吗？从源码逻辑看应该没有自执行了。 |
|
|
|
dist 只在发版本才会构建，目前仓库里的 dist 是旧的 |
对哦 |
|
构建个新的试试？@ @weizhenye |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.