This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Wrong add 1 to offset #189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2018
|
@noname007 I'm really sorry about my delay to get back to you about this one, way too many things at the same time. We have an interesting thing in your PR... all tests are passing, which is great, but since you didn't change any test it means we don't have ANY test that cover your specific situation. Could you please try to add a test that covers that? |
|
sorry i still don't know how to replay the problem by the tests #186 is my test scripts but not run i wanna it to be |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179