verify https://github.com/weiboad/kafka-php/issues/179

[noname007]

TDD may be good! but not the only thing in the world!!!!!!!

[lcobucci]

TDD may be good! but not the only thing in the world!!!!!!!

Considering the fact the test is being added after the code was done, this is not really TDD, right? However adding tests to the test suite is the only way to enforce that nasty bugs like this will ever happen again.

[lcobucci]

@noname007 can you please address the issues pointed out by Travis?

[noname007]

i was trying.....

[lcobucci]

@noname007 can I help you with anything?

[noname007]

i agree you point above.but don't agree the point only just use the test to prove the problem exsits.

[noname007]

@lcobucci yes , i wonder why my test was skipped?

[noname007]

i found this was skipped ,because missing env variables
Environment variables "KAFKA_VERSION", "KAFKA_TOPIC", and "KAFKA_BROKERS" must be provided

how i pass this to the test case?

[noname007]

https://travis-ci.org/weiboad/kafka-php/jobs/335624593

[lcobucci]

@noname007 if you look at the build stages in travis you'll see that the functional test suite was not executed because the previous stage failed. If you fix that it will execute your test in the functional test stage.

[noname007]

#189

[noname007]

@lcobucci i need your help to complete this test scripts for implement the desc in #188 #189