Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Content Block publish component generator #4495

Merged
merged 9 commits into from
Dec 3, 2024
Merged

feat: Content Block publish component generator #4495

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cb67fcd
fixture we want
istarkov Dec 2, 2024
b9267e8
Component generator
istarkov Dec 2, 2024
8c5b1c8
Update size
istarkov Dec 2, 2024
3131020
Remove check
istarkov Dec 2, 2024
8b62bc7
Fix TextToolbar
istarkov Dec 2, 2024
a7f289d
fix isolation
istarkov Dec 2, 2024
3fc366f
Add isolate on main too
istarkov Dec 2, 2024
50b0116
Add tests
istarkov Dec 2, 2024
89237a9
Fix
istarkov Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Component generator
  • Loading branch information
@istarkov
istarkov committed Dec 2, 2024
commit b9267e8b860fff9bc605fcf23b7de136c85b1bdd
15 changes: 14 additions & 1 deletion packages/react-sdk/src/component-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ import {
transpileExpression,
} from "@webstudio-is/sdk";
import { indexAttribute, isAttributeNameSafe, showAttribute } from "./props";
import { collectionComponent, descendantComponent } from "./core-components";
import {
blockComponent,
blockTemplateComponent,
collectionComponent,
descendantComponent,
} from "./core-components";
import type { IndexesWithinAncestors } from "./instance-utils";

/**
Expand Down Expand Up @@ -231,6 +236,10 @@ export const generateJsxElement = ({
}

let generatedElement = "";
if (instance.component === blockTemplateComponent) {
istarkov marked this conversation as resolved.
Show resolved Hide resolved
return "";
}

if (instance.component === collectionComponent) {
// prevent generating invalid collection
if (
Expand All @@ -246,6 +255,10 @@ export const generateJsxElement = ({
generatedElement += children;
generatedElement += `</Fragment>\n`;
generatedElement += `)}\n`;
} else if (instance.component === blockComponent) {
if (instance.children.length > 1) {
generatedElement += children;
}
istarkov marked this conversation as resolved.
Show resolved Hide resolved
} else {
const [_namespace, shortName] = parseComponentName(instance.component);
const componentVariable = scope.getName(instance.component, shortName);
Expand Down