Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Content Block publish component generator #4495

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 2, 2024

Description

1 commit = fixtures
2nd commit = code changes
3rd = size changes

ref #3994

Publish result:
https://webstudio-fixture-project-a-0su3o.wstd.work/content-block

See fixtures for generated code.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov mentioned this pull request Dec 2, 2024
58 tasks
@istarkov istarkov requested a review from TrySound December 2, 2024 15:15
@TrySound
Copy link
Member

TrySound commented Dec 2, 2024

A would add a couple basic tests to easier find the expected result

@istarkov istarkov requested a review from TrySound December 2, 2024 17:37
@istarkov
Copy link
Member Author

istarkov commented Dec 2, 2024

Tests added

@istarkov istarkov merged commit 3a87233 into main Dec 3, 2024
27 checks passed
@istarkov istarkov deleted the block.staging branch December 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants