fix: shrinkStrategy should always return an integer #645
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Buffer` inherits from `Uint8Arry` so the constructor needs to be called with integers and mustn't be called with floats. This patch ensures that the result of the the calculation in the `shrinkStrategy` in `Receiver` returns an integer. The reason why this has not been a problem up to now is that a there is a [V8 Bug](https://code.google.com/p/v8/issues/detail?id=4552) that the [spec](http://tc39.github.io/ecma262/#sec-typedarray-length) is not adhered in this case. This is a blocking issue for [Karma](karma-runner/karma#1768) as the upgrade to [core-js@2.0.0](https://github.com/zloirock/core-js) now enforces this error.
|
👍 |
1 similar comment
|
👍 |
3rd-Eden
added a commit
that referenced
this pull request
Dec 28, 2015
fix: shrinkStrategy should always return an integer
|
👍 |
|
can you make a release? we really need this for Karma to work |
|
Yes, that's really important 👍 Edit: Seem's to be there is a new release deployed |
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Jan 3, 2016
…wrapper - bug in `ws` module karma-runner/karma#1768 websockets/ws#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bufferinherits fromUint8Arryso the constructor needs to becalled with integers and mustn't be called with floats.
This patch ensures that the result of the the calculation
in the
shrinkStrategyinReceiverreturns an integer.The reason why this has not been a problem up to now is that
a there is a V8 Bug
that the spec
is not adhered in this case.
This is a blocking issue for Karma
as the upgrade to core-js@2.0.0
now enforces this error.