Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ws@1.0.0 #373

Closed
dignifiedquire opened this issue Dec 31, 2015 · 3 comments
Closed

Upgrade to ws@1.0.0 #373

dignifiedquire opened this issue Dec 31, 2015 · 3 comments

Comments

@dignifiedquire
Copy link
Contributor

Karma really needs this, as the current ws version is broken when used in combination with core-js. See karma-runner/karma#1768 (comment) and websockets/ws#645 for details on the bug and https://github.com/websockets/ws/releases/tag/1.0.0 for details on the release
@dignifiedquire dignifiedquire mentioned this issue Dec 31, 2015
Closed
@egoroof
Copy link

egoroof commented Dec 31, 2015

👍

@diwu1989
Copy link

diwu1989 commented Jan 1, 2016

really need a new release, thanks

dignifiedquire added a commit to dignifiedquire/engine.io that referenced this issue Jan 3, 2016
@dignifiedquire
Upgrade ws to 1.0.0
7b7aa2f 
Closes socketio#373
@dignifiedquire dignifiedquire mentioned this issue Jan 3, 2016
Merged
@ef4
Copy link

ef4 commented Jan 4, 2016

Make that 1.0.1, there's a critical vulnerability in prior versions: https://nodesecurity.io/advisories/67

dignifiedquire added a commit to dignifiedquire/engine.io that referenced this issue Jan 5, 2016
@dignifiedquire
Upgrade ws to 1.0.1
f685cfd 
Closes socketio#373
darrachequesne pushed a commit that referenced this issue May 8, 2020
@rauchg
Merge pull request #373 from rase-/update/bump-zuul-and-use-ngrok
24aa77e 
Bump zuul and use ngrok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ef4 @diwu1989 @dignifiedquire @egoroof