This repository has been archived by the owner on May 13, 2024. It is now read-only.
Connectivity test improvements #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha I was also working on this but did not have time to finish on Friday, anyway I submitted it now at b4548b4, it does address some more stuff than the connectivity tests, what are your thoughts? |
|
Ah, sorry to step on your toes :) |
|
No no I should have mentioned that I was working on it, step on my toes all you want ;) But feel free to comment on my PR with suggestions, I will address the comments already in there tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some points from #129 and #130
Doesn't solve the issue of whether to warn vs fail, but at least candidates get logged out now and the call is closed when each test ends.