Increase timeout for connectivity tests and add error message #130
Conversation
|
Since you are improving this test please do it properly... there is a lot of issues with it. |
KaptenJansson
force-pushed
the
increaseTimeout
branch
from
ee3d82e
to
b4548b4
Compare
| this.state = 'warning'; | ||
| } else if (this.isDisabled) { | ||
| this.state = 'disabled'; | ||
| } |
| if (event.data !== 'world') { | ||
| reportFatal(); | ||
| reportError('Data not transmitted.'); |
There was a problem hiding this comment.
nit but shouldn't the message read "Invalid data transmitted?"
There was a problem hiding this comment.
Yes indeed ;)
…e type for each test
| var call = new Call(config); | ||
| call.setIceCandidateFilter(iceCandidateFilter); | ||
|
|
||
| // Collect all candidate for validation. | ||
| call.pc1.onicecandidate = function(event) { |
There was a problem hiding this comment.
Nit: I prefer addEventListener('icecandidate', {...} ), I find it less error-prone in case there is multiple listeners.
Also it is used way more along this file.
There was a problem hiding this comment.
Yes sorry about that, should have ofc used addEventListener (I usually do...)
|
I'm gonna merge this now. Next up I will make a PR where the test object is passed to the test so that we do not have to use global report methods. |
Increase timeout for connectivity tests and add error message
Fixes #52